From: Михаил <dotnetfx@bk.ru>
To: linux-omap@vger.kernel.org
Subject: omap16xxcam module
Date: Tue, 20 May 2008 22:31:56 +0400 [thread overview]
Message-ID: <4833191C.7010204@bk.ru> (raw)
Hi, there. I work with OMAP5912 OSK. I've found some bugs in latest
(16/05/08) snapshot of git tree in omap16xxcam module. Here they are:
-------------------------omap16xxcam.c-------------------------------------------
/////////////////////////////////////////////////////////////////////////////////////////////
In function: omap16xx_cam_link_open
line 176: OMAP_DMA_CLNK_CTRL_REG(data->dma_channel_number1) =
data->dma_channel_number2; - udefined. I've looked into dma.h, and I
think that OMAP_DMA_CLNK_CTRL_REG should be replaced with
OMAP1_DMA_CLNK_CTRL. But even after all it'll be an error line, the
error is:
drivers/media/video/omap/omap16xxcam.c:176: error: lvalue required as
left operand of assignment.
line 178: the same error.
//////////////////////////////////////////////////////////////////////////////////////////
In function: omap16xxcam_start_dma
line 342: s/OMAP_DMA_CLNK_CTRL_REG/OMAP1_DMA_CLNK_CTRL/g
line 352: s/OMAP_DMA_CCR_REG/OMAP1_DMA_CCR/g
//////////////////////////////////////////////////////////////////////////////////////////
Here "make" command log after all changes in source:
drivers/media/video/omap/omap16xxcam.c: In function ‘omap16xx_cam_link_open’
drivers/media/video/omap/omap16xxcam.c:177: error: lvalue required as
left operand of assignment
drivers/media/video/omap/omap16xxcam.c:179: error: lvalue required as
left operand of assignment
drivers/media/video/omap/omap16xxcam.c: In function ‘omap16xxcam_start_dma’
drivers/media/video/omap/omap16xxcam.c:342: error: lvalue required as
left operand of assignment
drivers/media/video/omap/omap16xxcam.c:352: error: lvalue required as
left operand of assignment
make[4]: *** [drivers/media/video/omap/omap16xxcam.o] Error 1
make[3]: *** [drivers/media/video/omap] Error 2
make[2]: *** [drivers/media/video] Error 2
make[1]: *** [drivers/media] Error 2
make: *** [drivers] Error 2
-------------------------omap16xxcam.c-------------------------------------------
But even after all changes, if you'll comment error lines, just for a
test it will not successfully build. The error log will looks like this:
------------------------------cut-------------------------------------------
ERROR: "v4l2_int_ioctl_1" [drivers/media/video/omap/omapcamera.ko]
undefined!
ERROR: "v4l2_int_ioctl_0" [drivers/media/video/omap/omapcamera.ko]
undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
------------------------------cut-------------------------------------------
Any ideas ?
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2008-05-20 18:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4833191C.7010204@bk.ru \
--to=dotnetfx@bk.ru \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox