From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Benoit Cousson <b-cousson@ti.com>, Rajendra Nayak <rnayak@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>, linux-omap@vger.kernel.org
Subject: RE: Integration branch base switchover to Tony's omap-for-linus branch
Date: Fri, 4 Mar 2011 20:31:59 +0530 [thread overview]
Message-ID: <4837f9c890c8a6c38d346cac73d9cec6@mail.gmail.com> (raw)
In-Reply-To: <4D70FE4A.8060600@ti.com>
> -----Original Message-----
> From: Cousson, Benoit [mailto:b-cousson@ti.com]
> Sent: Friday, March 04, 2011 8:29 PM
> To: Nayak, Rajendra
> Cc: Paul Walmsley; Shilimkar, Santosh; linux-omap@vger.kernel.org
> Subject: Re: Integration branch base switchover to Tony's omap-for-
> linus branch
>
> Hi Rajendra,
>
> On 3/4/2011 3:08 PM, Nayak, Rajendra wrote:
> > Hi Paul,
>
> [...]
>
> > This however is still not rootcaused and is not the same as the
> issue
> > seen with i2c as the WE for GPT1 is already programmed for
> enabling
> > wakeup.
> >
> > The one way to fix this for now is to put GPT1 block in software
> > controlled idle as was done by your test patch for i2c.
> >
> > ---
> > From fde94c22bb2db233b0b0cc4c2024d6f4e9f95257 Mon Sep 17
> 00:00:00 2001
> > From: Rajendra Nayak<rnayak@ti.com>
> > Date: Fri, 4 Mar 2011 19:33:45 +0530
> > Subject: [PATCH] OMAP4: hwmod: Disable hardware-controlled idle
> for GPT1
>
> Maybe we should emphasis the temporary need for this commit to avoid
> forgetting it?
>
> > Some issues seen (which cause lockups in suspend) with GPT1
> > after the MPU<->L4_WKUP static dependency was cleared can be
> > Worked-around for now by forcing GPT1 in software
> > controlled idle.
> >
> > Signed-off-by: Rajendra Nayak<rnayak@ti.com>
> > ---
> > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> > b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> > index 2c58827..9317a05 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> > @@ -3989,7 +3989,7 @@ static struct omap_hwmod_ocp_if
> > *omap44xx_timer1_slaves[] = {
> > static struct omap_hwmod omap44xx_timer1_hwmod = {
> > .name = "timer1",
> > .class =&omap44xx_timer_1ms_hwmod_class,
> > - .flags = HWMOD_INIT_NO_IDLE |
> HWMOD_INIT_NO_RESET,
> > + .flags = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET
> |
> > HWMOD_SWSUP_SIDLE,
>
> I was wondering why the previous flags were still there, but it
> looks
> like the revert was not done.
>
> I'll push it with the revert for the flags.
>
> Where is the Santosh's branch that should be rebased on top of that
> one?
>
I am trying to rebase it on Kevin's pm-core branch. Will cherry pick
these patches
next prev parent reply other threads:[~2011-03-04 15:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 0:26 Integration branch base switchover to Tony's omap-for-linus branch Paul Walmsley
2011-03-01 12:38 ` Santosh Shilimkar
2011-03-01 21:33 ` Paul Walmsley
2011-03-03 12:30 ` Rajendra Nayak
2011-03-04 14:08 ` Rajendra Nayak
2011-03-04 14:59 ` Cousson, Benoit
2011-03-04 15:01 ` Santosh Shilimkar [this message]
2011-03-04 15:25 ` Cousson, Benoit
2011-03-04 16:43 ` Santosh Shilimkar
2011-03-08 15:16 ` Santosh Shilimkar
2011-03-08 16:28 ` Cousson, Benoit
2011-03-09 5:08 ` Santosh Shilimkar
2011-03-07 23:25 ` Paul Walmsley
2011-03-08 8:04 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4837f9c890c8a6c38d346cac73d9cec6@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).