Re: [PATCH] ARM: OMAP3: Make I2C bus 2 configurable for BeagleBoard

[Dirk Behme <dirk.behme@googlemail.com>]

Jarkko Nikula wrote:
> On Fri, 04 Jul 2008 08:26:55 +0200
> "ext Dirk Behme" <dirk.behme@googlemail.com> wrote:
> 
> 
>>- Add configuration option for this
>>- Use configuration option in board-omap3beagle
>>- Ensure correct pin mux if I2C2 is enabled, independent of settings 
>>done by bootloader
>>
> 
> Why this CONFIG_I2C2_OMAP_BEAGLE in mux.c?

Because bootloader, e.g. uboot, might have set other mux for these 
pins, e.g. GPIO168 and GPIO183.

Then, if CONFIG_MUX is enabled but I2C2 isn't, don't touch the pin mux 
done by bootloader. But if I2C2 is enabled, make sure that the correct 
mux settings are done independent of bootloader.

Do you think this is wrong?

Thanks

Dirk

> --- linux-beagle.orig/arch/arm/mach-omap2/mux.c
> +++ linux-beagle/arch/arm/mach-omap2/mux.c
> @@ -231,10 +231,12 @@ MUX_CFG_34XX("K21_34XX_I2C1_SCL", 0x1ba,
>  		OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_INPUT_PULLUP)
>  MUX_CFG_34XX("J21_34XX_I2C1_SDA", 0x1bc,
>  		OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_INPUT_PULLUP)
> +#ifdef CONFIG_I2C2_OMAP_BEAGLE
>  MUX_CFG_34XX("AF15_34XX_I2C2_SCL", 0x1be,
>  		OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_INPUT_PULLUP)
>  MUX_CFG_34XX("AE15_34XX_I2C2_SDA", 0x1c0,
>  		OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_INPUT_PULLUP)
> +#endif
>  MUX_CFG_34XX("AF14_34XX_I2C3_SCL", 0x1c2,
>  		OMAP34XX_MUX_MODE0 | OMAP34XX_PIN_INPUT_PULLUP)
>  MUX_CFG_34XX("AG14_34XX_I2C3_SDA", 0x1c4,
> 
>