From: Adrian Hunter <ext-adrian.hunter@nokia.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, madhu.cr@ti.com
Subject: Re: Bug in twl4030backupbatt_voltage()
Date: Wed, 10 Sep 2008 10:28:30 +0300 [thread overview]
Message-ID: <48C7771E.6080307@nokia.com> (raw)
In-Reply-To: <20080909174214.GP29054@atomide.com>
Tony Lindgren wrote:
> * Adrian Hunter <ext-adrian.hunter@nokia.com> [080903 08:08]:
>> In the omap tree, commit f91fd98be045bec9c18e13110f22dafd44cb84b5
>> fixed a bug with the use of function twl4030_madc_conversion()
>> relating to the local variable 'struct twl4030_madc_request req'
>> not being fully initialised.
>>
>> The same problem appears to be in the function
>> twl4030backupbatt_voltage() which is in drivers/power/twl4030_bci_battery.c
>
> Thanks, I'll initialize it to NULL. Wouldn't it have been easier just
> to write a patch instead of the description above? :)
Apparently.
There is also req.do_avg which should be zero, if you assume the programmer's
intent was to have uninitialised members set to zero.
next prev parent reply other threads:[~2008-09-10 7:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 15:10 Bug in twl4030backupbatt_voltage() Adrian Hunter
2008-09-09 17:42 ` Tony Lindgren
2008-09-10 7:28 ` Adrian Hunter [this message]
2008-09-10 13:12 ` Madhusudhan Chikkature
2008-09-10 15:39 ` Tony Lindgren
2008-09-11 3:32 ` Madhusudhan Chikkature
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C7771E.6080307@nokia.com \
--to=ext-adrian.hunter@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox