From: Kevin Hilman <khilman@deeprootsystems.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 07/12] System Control Module context save/restore
Date: Thu, 11 Sep 2008 08:33:59 +0300 [thread overview]
Message-ID: <48C8ADC7.9020109@deeprootsystems.com> (raw)
In-Reply-To: <012e01c913cb$6e5c6e90$LocalHost@wipultra1382>
Rajendra Nayak wrote:
>
>
>> -----Original Message-----
>> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
>> Sent: Wednesday, September 10, 2008 8:18 PM
>> To: Rajendra Nayak
>> Cc: linux-omap@vger.kernel.org
>> Subject: Re: [PATCH 07/12] System Control Module context save/restore
>>
>> "Rajendra Nayak" <rnayak@ti.com> writes:
>>
>>> This patch adds the System control module context save/restore
>>>
>>> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
>>> ---
>>> arch/arm/mach-omap2/control.c | 105
>> ++++++++++++++++++++++++++++++
>>> arch/arm/plat-omap/include/mach/control.h | 61 +++++++++++++++++
>>> 2 files changed, 165 insertions(+), 1 deletion(-)
>>>
>>> Index: linux-omap-2.6/arch/arm/mach-omap2/control.c
>>> ===================================================================
>>> --- linux-omap-2.6.orig/arch/arm/mach-omap2/control.c
>> 2008-09-01
>>> 18:11:34.000000000 +0530
>>> +++ linux-omap-2.6/arch/arm/mach-omap2/control.c
>> 2008-09-01 18:11:54.000000000
>>> +0530
>>> @@ -73,6 +73,8 @@ void omap_ctrl_writel(u32 val, u16 offse
>>>
>>> #define OMAP3430_PRM_RSTST \
>>> OMAP34XX_PRM_REGADDR(OMAP3430_GR_MOD, RM_RSTST)
>>> +static struct omap3_control_module_regs control_ctx;
>>> +
>> I'm not sure what this patch was generated against, but it doesn't
>> apply against linux-omap. The PRM_RSTST definition above is not in
>> linux-omap code.
>>
>> Kevin
>
> There is no reference to PRM_RSTST in this patch. It uses RM_RSTST which
> can be found in arch/arm/mach-omap2/prm.h.
You can see in the above quoted text that your 7/12 patch adds some code
immediately after a line which defines OMAP3430_PRM_RSTST. Since this
existing code is not in linux-omap, and I couldn't find it in previous
patches, it's not clear what this patch was generated against.
Kevin
next prev parent reply other threads:[~2008-09-11 5:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 13:40 [PATCH 07/12] System Control Module context save/restore Rajendra Nayak
2008-09-04 9:15 ` Kevin Hilman
2008-09-10 14:47 ` Kevin Hilman
2008-09-11 5:01 ` Rajendra Nayak
2008-09-11 5:33 ` Kevin Hilman [this message]
2008-09-11 6:52 ` Rajendra Nayak
2008-09-11 7:32 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C8ADC7.9020109@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox