From: Kevin Hilman <khilman@deeprootsystems.com>
To: David Brownell <david-b@pacbell.net>
Cc: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] Debobs and ETK padconf implementation
Date: Thu, 25 Sep 2008 23:28:15 +0300 [thread overview]
Message-ID: <48DBF45F.7020601@deeprootsystems.com> (raw)
In-Reply-To: <200809251004.12962.david-b@pacbell.net>
David Brownell wrote:
> On Thursday 25 September 2008, Kevin Hilman wrote:
>>>> In that case, what is the proposed method for other kernel code to use
>>>> the debobs lines?
>>> Hmm, good point :) My idea was to use the gpiolib calls on GPIO12 -
>>> GPIO29, but then there is no way for a user to know if the GPIO was
>>> assigned to debobs or not... Maybe debobs should register as gpiolib
>>> 'chip' and reexport those lines ? Would that make sense ?
>>
>> I think debobs should simply 'gpio_export' each pin. It does not need
>> to hold them.
>
> Peter said the right abstraction here was pads (pins/balls?) not
> GPIOs, so I'm not sure this is relevant any more, but ...
>
> You can't gpio_export() to userspace, via sysfs, without having
> first done a gpio_request(). And then later a gpio_free() will
> release that export. So that won't work.
Thanks Dave, I was kind of hoping you would chime in on this one :)
OK, then I guess Peter's idea of a gpio_chip type abstraction makes more
sense.
But I'm still not sure how to best deal with the possibiltity that the
pin might not always be a GPIO, but might be reconfigured/re-mux'd by
this debobs interface as a debug observability pin. My initial thought
was to have the debobs interface gpio_request() the line if it was in
observability mode so that nobody else could use it as a GPIO line, then
gpio_free() it when it was put back into GPIO mode thus making it
available to other users as a GPIO. While that may work, it seems
counter-intuitive and rather kludgy. Not sure what the best way is...
Kevin
next prev parent reply other threads:[~2008-09-25 20:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 15:02 [PATCH] debobs support for OMAP3430 Peter 'p2' De Schrijver
2008-09-17 15:02 ` [PATCH] Add definitions for ETK pads and debobs registers Peter 'p2' De Schrijver
2008-09-17 15:02 ` [PATCH] Debobs and ETK padconf implementation Peter 'p2' De Schrijver
2008-09-17 15:02 ` [PATCH] Add debobs Kconfig item Peter 'p2' De Schrijver
2008-09-25 8:58 ` Kevin Hilman
2008-09-25 8:56 ` [PATCH] Debobs and ETK padconf implementation Kevin Hilman
2008-09-25 11:35 ` Peter 'p2' De Schrijver
2008-09-25 11:40 ` Kevin Hilman
2008-09-25 11:52 ` Peter 'p2' De Schrijver
2008-09-25 12:06 ` Peter 'p2' De Schrijver
2008-09-25 12:31 ` Kevin Hilman
2008-09-25 17:04 ` David Brownell
2008-09-25 20:28 ` Kevin Hilman [this message]
2008-09-25 20:37 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2008-09-16 9:51 [PATCH] debobs support for OMAP3430 Peter 'p2' De Schrijver
2008-09-16 9:51 ` [PATCH] Add definitions for ETK pads and debobs registers Peter 'p2' De Schrijver
2008-09-16 9:51 ` [PATCH] Debobs and ETK padconf implementation Peter 'p2' De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DBF45F.7020601@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox