From: Felipe Balbi <me@felipebalbi.com>
To: Arun KS <getarunks@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [Resend] [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)
Date: Tue, 24 Jun 2008 09:18:27 -0500 [thread overview]
Message-ID: <48e8658f507de35e2fab060ca2a9db43@felipebalbi.com> (raw)
In-Reply-To: <dfeb90390806240625y7c1309fal44dce5ce3f7f62c1@mail.gmail.com>
Hi,
On Tue, 24 Jun 2008 18:55:26 +0530, "Arun KS" <getarunks@gmail.com> wrote:
> +static inline void __init omap2evm_init_smc911x(void)
> +{
> + int gpio = OMAP2EVM_ETHR_GPIO_IRQ;
> + int ret;
> +
> + ret = gpio_request(gpio, "smc911x IRQ");
> + if (ret >= 0)
> + gpio_direction_input(gpio);
> + else
> + printk(KERN_ERR "Failed to request GPIO for smc911x
this would look better like this:
if (ret < 0) {
printk(KERN_ERR "Failed to request GPIO %d for smc911x IRQ\n",
gpio);
return;
}
gpio_direction_input(gpio);
besides this, it looks fine :-)
--
Best Regards,
Felipe Balbi
http://felipebalbi.com
me@felipebalbi.com
next prev parent reply other threads:[~2008-06-24 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 12:04 [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x) Arun KS
2008-06-24 12:12 ` Felipe Balbi
2008-06-24 12:29 ` Arun KS
2008-06-24 12:54 ` Arun KS
2008-06-24 12:57 ` Felipe Balbi
2008-06-24 13:25 ` [Resend] " Arun KS
2008-06-24 14:18 ` Felipe Balbi [this message]
2008-06-24 14:50 ` Arun KS
2008-06-24 15:06 ` Arun KS
2008-06-24 15:25 ` Felipe Balbi
2008-06-24 15:41 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48e8658f507de35e2fab060ca2a9db43@felipebalbi.com \
--to=me@felipebalbi.com \
--cc=getarunks@gmail.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox