From: Sakari Ailus <sakari.ailus@nokia.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [RFC] i2c-omap: Don't wait needlessly
Date: Mon, 27 Oct 2008 18:20:38 +0200 [thread overview]
Message-ID: <4905EA56.5050309@nokia.com> (raw)
In-Reply-To: <20081024131740.64641d26.jarkko.nikula@nokia.com>
Jarkko Nikula wrote:
> I would rather, if there is no need for such a long delay like
> OMAP_I2C_TIMEOUT, remove that time_after and msleep(1) stuff and
> just loop few iterations with udelay(1). Zero thinked & tested diff
> attached.
I just though of allowing the reset to take longer as I have no idea how
long it could take, let alone other versions of OMAP.
> I would say that ndelay(1) just doesn't look relevant to < 1 GHz
> cpus :-)
Good point. On ARM ndelay(1) seems to be equal to udelay(1) at the moment.
I actually just removed the ndelay(1) and again, "delay" won't get past
1 if I print it after the loop.
It'd be nice to know how it works on other OMAP versions before making
such changes. :-)
--
Sakari Ailus
sakari.ailus@nokia.com
next prev parent reply other threads:[~2008-10-27 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 16:19 [RFC] i2c-omap: Don't wait needlessly Sakari Ailus
2008-10-24 10:17 ` Jarkko Nikula
2008-10-27 16:20 ` Sakari Ailus [this message]
2008-11-21 21:43 ` Tony Lindgren
2008-11-25 9:35 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4905EA56.5050309@nokia.com \
--to=sakari.ailus@nokia.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox