From: Kevin Hilman <khilman@deeprootsystems.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, tomi.valkeinen@nokia.com,
rick@efn.org, timo.t.kokkonen@nokia.com, sakari.poussa@nokia.com
Subject: Re: [PATCH] OMAP3 clock: fix non-CORE DPLL rate assignment bugs
Date: Wed, 05 Nov 2008 15:43:43 -0800 [thread overview]
Message-ID: <49122FAF.1020109@deeprootsystems.com> (raw)
In-Reply-To: <49075870.9020804@deeprootsystems.com>
Kevin Hilman wrote:
> Paul Walmsley wrote:
>> Commit 8b1f0bd44fe490ec631230c8c040753a2bda8caa introduced a bug that
>> caused non-CORE DPLL rates to be incorrectly set on boot in
>> omap3_noncore_dpll_enable(). Debugged by Tomi Valkeinen
>> <tomi.valkeinen@nokia.com> - thanks Tomi.
>>
>> Also fix omap3_noncore_dpll_set_rate() to assign clk->rate after a
>> DPLL reprogram.
>>
>> Tested on 3430SDP.
>
> FYI, This patch breaks the ability to come out of retention in dynamic
> idle, but I haven't yet discovered why.
>
It appears this is related to the UART patches being used in the PM
branch, and not this patch.
I have a (forthcoming) set of UART updates that will allow the UART to
disable its clocks and enable the chip to hit retention.
Kevin
prev parent reply other threads:[~2008-11-05 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 22:18 [PATCH] OMAP3 clock: fix non-CORE DPLL rate assignment bugs Paul Walmsley
2008-10-17 22:46 ` Tony Lindgren
2008-10-28 18:22 ` Kevin Hilman
2008-10-29 14:24 ` Paul Walmsley
2008-10-29 16:35 ` Kevin Hilman
2008-10-29 16:47 ` Paul Walmsley
2008-11-05 23:43 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49122FAF.1020109@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rick@efn.org \
--cc=sakari.poussa@nokia.com \
--cc=timo.t.kokkonen@nokia.com \
--cc=tomi.valkeinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).