From: Adrian Hunter <ext-adrian.hunter@nokia.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
dwmw2@infradead.org
Subject: Re: Please fix or remove OMAP2 onenand driver
Date: Mon, 24 Nov 2008 13:37:05 +0200 [thread overview]
Message-ID: <492A91E1.50305@nokia.com> (raw)
In-Reply-To: <20081123165011.GB17438@flint.arm.linux.org.uk>
Russell King - ARM Linux wrote:
> Clearly this driver has been put into mainline prematurely - it takes
> no account of the relocation of headers.
>
> It's causing a regression - omap_2430sdp_defconfig used to build in
> mainline, and it no longer does.
>
> Please fix, or remove this broken driver from mainline.
From: Adrian Hunter <ext-adrian.hunter@nokia.com>
Date: Mon, 24 Nov 2008 13:34:53 +0200
Subject: [PATCH] MTD: OMAP: OneNAND: header file relocation
Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
---
drivers/mtd/onenand/omap2.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index e39b21d..28034ef 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -35,16 +35,16 @@
#include <asm/io.h>
#include <asm/mach/flash.h>
-#include <asm/arch/gpmc.h>
-#include <asm/arch/onenand.h>
-#include <asm/arch/gpio.h>
-#include <asm/arch/pm.h>
+#include <mach/gpmc.h>
+#include <mach/onenand.h>
+#include <mach/gpio.h>
+#include <mach/pm.h>
#include <linux/dma-mapping.h>
#include <asm/dma-mapping.h>
-#include <asm/arch/dma.h>
+#include <mach/dma.h>
-#include <asm/arch/board.h>
+#include <mach/board.h>
#define DRIVER_NAME "omap2-onenand"
--
1.5.4.3
next prev parent reply other threads:[~2008-11-24 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-23 16:50 Please fix or remove OMAP2 onenand driver Russell King - ARM Linux
2008-11-24 11:37 ` Adrian Hunter [this message]
2008-11-24 12:01 ` Russell King - ARM Linux
2008-11-24 12:44 ` Adrian Hunter
2008-11-26 9:57 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492A91E1.50305@nokia.com \
--to=ext-adrian.hunter@nokia.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox