From: Sakari Ailus <sakari.ailus@nokia.com>
To: ext Hans Verkuil <hverkuil@xs4all.nl>
Cc: v4l <video4linux-list@redhat.com>,
"Tuukka.O Toivonen" <tuukka.o.toivonen@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: Extended driver private controls?
Date: Thu, 08 Jan 2009 17:46:50 +0200 [thread overview]
Message-ID: <49661FEA.5020409@nokia.com> (raw)
In-Reply-To: <200812191548.34238.hverkuil@xs4all.nl>
ext Hans Verkuil wrote:
> Hi Sakari,
Hello,
...
> What I did to support private controls is to allow drivers to add their own
> controls to the various classes, as long as the low 16 bits are >= 0x1000.
>
> You add them to videodev2.h (see the CX2341X private controls), and you just
> pick a starting base such as 'V4L2_CTRL_CLASS_MPEG | 0x1100'.
>
> This way the controls are together in one header, they have unique IDs, and
> you can assign them to a specific class.
...
> So, to summarize: for new drivers I recommend using V4L2_CTRL_FLAG_NEXT_CTRL
> and adding the private controls to videodev2.h and to prepare documentation
> for inclusion with the v4l2 spec. If you really must support old apps, then
> you might have to make duplicate PRIVATE_BASE controls (yuck!), but I hope
> that won't be necessary.
Thanks, Hans, for the definitive answer. This is what we'll do then.
Cheers,
--
Sakari Ailus
sakari.ailus@nokia.com
next prev parent reply other threads:[~2009-01-08 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <494B59B5.2030800@nokia.com>
2008-12-19 14:48 ` Extended driver private controls? Hans Verkuil
2009-01-08 15:46 ` Sakari Ailus [this message]
2009-01-08 16:30 ` Aguirre Rodriguez, Sergio Alberto
2009-01-08 17:15 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49661FEA.5020409@nokia.com \
--to=sakari.ailus@nokia.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-omap@vger.kernel.org \
--cc=tuukka.o.toivonen@nokia.com \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox