From: Adrian Hunter <ext-adrian.hunter@nokia.com>
To: Pierre Ossman <drzeus-mmc@drzeus.cx>
Cc: Tony Lindgren <tony@atomide.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
lkml <linux-kernel@vger.kernel.org>,
linux-omap Mailing List <linux-omap@vger.kernel.org>,
"Lavinen Jarkko (Nokia-M/Helsinki)" <jarkko.lavinen@nokia.com>,
Madhusudhan Chikkature <madhu.cr@ti.com>
Subject: Re: [PATCH 2/2] OMAP: HSMMC: Fix response type for busy after response
Date: Tue, 13 Jan 2009 16:19:48 +0200 [thread overview]
Message-ID: <496CA304.9000802@nokia.com> (raw)
In-Reply-To: <20090113144952.3f8cbec8@mjolnir.drzeus.cx>
Pierre Ossman wrote:
> On Tue, 13 Jan 2009 15:38:41 +0200
> Adrian Hunter <ext-adrian.hunter@nokia.com> wrote:
>
>> This also fixes the hidden problem that the controller
>> was turning off the clock to the card while the card
>> was busy - the clock was then switched on for the
>> duration of each Send Status command used for polling,
>> which is why writes did not lock up altogether.
>> i.e. really dysfunctional.
>
> Does the driver only keep the clock running as long as there is an
> ongoing request? That kind of policy should really be handled in the
> core where we have more information and can control it better. E.g. some
> cards need the clock to finish up internal housekeeping so we need to
> delay things for those.
>
> Rgds
Unfortunately it seems to be something the controller does by itself,
beyond the control of the driver. Added Jarkko Lavinen and
Madhusudhan Chikkature to CC, maybe they can correct me.
If it obeys the standard, it should give an additional 8 clock cycles.
next prev parent reply other threads:[~2009-01-13 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 13:38 [PATCH 0/2] omap_hsmmc patches Adrian Hunter
2009-01-13 13:38 ` [PATCH 1/2] OMAP: HSMMC: Do dma cleanup also with data CRC errors Adrian Hunter
2009-01-13 13:38 ` [PATCH 2/2] OMAP: HSMMC: Fix response type for busy after response Adrian Hunter
2009-01-13 13:49 ` Pierre Ossman
2009-01-13 14:19 ` Adrian Hunter [this message]
2009-01-14 10:19 ` Adrian Hunter
2009-01-14 10:21 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496CA304.9000802@nokia.com \
--to=ext-adrian.hunter@nokia.com \
--cc=drzeus-mmc@drzeus.cx \
--cc=jarkko.lavinen@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=madhu.cr@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox