From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Hunter Subject: Re: [PATCH] OMAP HSMMC: fix MMC3 dma Date: Wed, 28 Jan 2009 10:35:09 +0200 Message-ID: <498018BD.2000806@nokia.com> References: <1233052573-6223-1-git-send-email-notasas@gmail.com> <497EF7E2.7010906@nokia.com> <6ed0b2680901270900t24838c73l3aa8edca62c91710@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.nokia.com ([192.100.122.230]:33940 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752829AbZA1IWb (ORCPT ); Wed, 28 Jan 2009 03:22:31 -0500 In-Reply-To: <6ed0b2680901270900t24838c73l3aa8edca62c91710@mail.gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Grazvydas Ignotas Cc: "tony@atomide.com" , "drzeus-mmc@drzeus.cx" , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" Grazvydas Ignotas wrote: > On Tue, Jan 27, 2009 at 2:02 PM, Adrian Hunter > wrote: >> Grazvydas Ignotas wrote: >>> Data transfers on third OMAP3 MMC controller don't work >>> because DMA line numbers are only defined for MMC1 and MMC2. >>> Fix that and store line numbers in mmc_omap_host structure >>> to reduce code size. >>> Tested on OMAP3 pandora board. >>> >>> Signed-off-by: Grazvydas Ignotas >>> --- >>> drivers/mmc/host/omap_hsmmc.c | 31 +++++++++++++++++++++++-------- >>> 1 files changed, 23 insertions(+), 8 deletions(-) >>> >> Have you considered using the scatter-gather emulation patch: >> >> http://marc.info/?l=linux-omap&m=122726069922195&w=2 >> >> It was reverted: >> >> http://marc.info/?l=linux-omap&m=122904725322787&w=2 >> >> because of a hardware problem with OMAP3430 before ES3.0, but applying: >> >> >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=6a79e391df295bd7c2aa1309ea5031f361c197fd >> >> seems to overcome even that. > > Hmm, but it still doesn't know about MMC3. But in case that SG patch > goes first, I can resend. I just meant, you might be interested because it gives better performance. No, it doesn't know about MMC3, but it does hit some of the same lines of code.