From: Sergei Shtylyov <sshtylyov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
To: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org,
felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 2/3] usb: musb: fix bug in musb_start_urb
Date: Fri, 06 Feb 2009 18:03:55 +0300 [thread overview]
Message-ID: <498C515B.20603@ru.mvista.com> (raw)
In-Reply-To: <1233921146-4046-1-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
Ajay Kumar Gupta wrote:
> urb->transfer_buffer_length and urb->transfer_buffer should be
> updated based on urb->actual_length.For a fresh and first time urb,
> actual_length will be zero but for urbs which has been stopped and
> restarted (as bulk nak scheme does) actual_length may not be zero.
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
NAK, this is not a problem for the current driver since URBs do not ever
get restarted. Also, musb_host_tx() doesn't update urb->actual_length --
please fix it too. Also, you must not clear qh->iso_idx when restarting -- you
must not start ISO transfer all over again too. Also, you should not set
musb->ep0_state to MUSB_EP0_START again in this case (I agree that control
transfers will remain not restartable from an arbitatry place even then). If
you're trying to make musb_start_urb() able to re-start, please be consistent.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-02-06 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 11:52 [PATCH 2/3] usb: musb: fix bug in musb_start_urb Ajay Kumar Gupta
[not found] ` <1233921146-4046-1-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2009-02-06 15:03 ` Sergei Shtylyov [this message]
2009-02-23 22:05 ` David Brownell
2009-02-24 15:50 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498C515B.20603@ru.mvista.com \
--to=sshtylyov-hkdhdckh98+b+jhodadfcq@public.gmane.org \
--cc=ajay.gupta-l0cyMroinI0@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox