From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Hunter Subject: Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming Date: Mon, 23 Feb 2009 10:04:50 +0200 Message-ID: <49A258A2.2020408@nokia.com> References: <4d34a0a70902200400s252f48ddvfd6e0d83e91fa291@mail.gmail.com> <200902201311.44056.david-b@pacbell.net> <4d34a0a70902222141y345a7bc3g314e6de5df156f2d@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=EUC-KR Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.nokia.com ([192.100.122.230]:22967 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752715AbZBWHuo (ORCPT ); Mon, 23 Feb 2009 02:50:44 -0500 In-Reply-To: <4d34a0a70902222141y345a7bc3g314e6de5df156f2d@mail.gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kim Kyuwon Cc: David Brownell , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "drzeus-mmc@drzeus.cx" , =?EUC-KR?B?seix1L/4?= , =?EUC-KR?B?udqw5rnO?= ext Kim Kyuwon wrote: > Hi, > > On Sat, Feb 21, 2009 at 6:11 AM, David Brownell wrote: >> On Friday 20 February 2009, Kim Kyuwon wrote: >>> +static void omap_hsmmc_init(struct mmc_omap_host *host) >>> +{ >>> + u32 hctl, capa, value; >>> + >>> + /* Only MMC1 supports 3.0V */ >>> + if (host->id == OMAP_MMC1_DEVID) { >>> + hctl = SDVS30; >> Shouldn't it be remembering what voltage it was using, >> and then restore that, instead of always making MMC1 >> restart at a 3.0V level? That's pretty awkward to test >> unless you have a 1.8V-capable card in MMC1... > > You are somewhat right, thank you. > But remebering what voltage it was using doesn't feasible to me, > because the card can be changed while in 'Sleep' state. I should have > inserted a function that detect the right voltage after intializing. I > will resend the patch later. Doesn't it already do that? Can you explain more? Although I have not tested it, I very much doubt dual-voltage cards work. That is because VMMC1_185V is zero, which has the side-effect of turning the regulator off (see arch/arm/mach-omap2/mmc-twl4030.c)