From: Adrian Hunter <ext-adrian.hunter@nokia.com>
To: David Brownell <david-b@pacbell.net>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [patch 2.6.29-rc5-omap-git] mach-omap2/mmc-twl4030: fix for vmmc = 0
Date: Tue, 24 Feb 2009 13:48:56 +0200 [thread overview]
Message-ID: <49A3DEA8.1050909@nokia.com> (raw)
In-Reply-To: <200902231014.26352.david-b@pacbell.net>
David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Resolve longstanding issue noted by Adrian Hunter: confusion
> between settting VSEL=0 (which is 1.8V on MMC1) and poweroff.
>
> Also, leave VSEL alone if we're just powering the regulator off.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
Looks fine to me, but I wonder if you know why the regulator is
turned on (DEV_GRP) and then the voltage is selected (DEDICATED).
Wouldn't it make more sense the other way around? Doesn't
the new regulator framework do it that way?
next prev parent reply other threads:[~2009-02-24 11:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 18:14 [patch 2.6.29-rc5-omap-git] mach-omap2/mmc-twl4030: fix for vmmc = 0 David Brownell
2009-02-24 11:48 ` Adrian Hunter [this message]
2009-02-24 20:13 ` David Brownell
2009-02-25 9:45 ` Adrian Hunter
2009-02-25 10:04 ` David Brownell
2009-02-27 21:52 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A3DEA8.1050909@nokia.com \
--to=ext-adrian.hunter@nokia.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox