Re: [PATCH] DSPBRIDGE Fix for auto image load updated

[Ameya Palande <ameya.palande@nokia.com>]

Hi Ramesh,

ext Gupta, Ramesh wrote:
> Ameya,
>  
> 
>>>  
>> Hi Ramesh,
>>
>> I am not clear about the issue which this patch fixes.
>> As I understand that:
>>
>> 1. You have increased the count for 
>> pdata->mpu_speed[i] = vdd1_rate_table_bridge[i].rate;
>>
>> 2. Moved driverContext = DSP_Init(&initStatus) after 
>> clk_notifier_register stuff.
> 
> These 2 changes fix the issue.
> 
>> 3. Coding Style cleanups.
> 
> This is to fix only the checkpatch warnings.
> 
>> I am not able to understand what this patch is fixing and how?
>> Some explanation about this will be helpful.
> 
> Clock registration is called after DSP_Init mistakenly , the image autoloading loads PROC_Load
> Inturn that calls for OPP boosting while loading the image , this fails as the clock registration is not called.
> 
> There was a typo in filling the platform data (5 instead of 6) because of that, the OPP5 frequency value is not updated, that causes WARN_ON()
> In the SRF.
> 
> Please let me know if you need any more information on these changes.
> 
> Thanks
> Ramesh Gupta G

Just by looking at the patch these things were not clear to me.
Thanks a lot for your quick reply :)

Cheers,
Ameya.