Re: [patch 2.6.29-rc7-omap 5/5] mmc-twl4030 uses regulator framework

[Adrian Hunter <adrian.hunter@nokia.com>]

ext David Brownell wrote:
> On Thursday 12 March 2009, Adrian Hunter wrote:
>>> +               }
>>>         } else {
>>> -               ret = twl_mmc_set_voltage(c, 0);
>>> +               if (c->vcc_aux)
>>> +                       ret = regulator_enable(c->vcc_aux);
>> Sorry for slow reply.  Shouldn't that be regulator_disable() ?
> 
> Indeed it should be.  In fact I think this probably explains
> the failure I saw the other day, trying to go from 3.3V on one
> chip down to 1.8V, where it failed (reasons unknown so far)
> but the cleanup left vcc_aux active.  Got patch?  :)
> 
> I meant this one to be a patch/RFC ... so you could see how I
> thought those issues should be addressed, vs the less general
> patches you sent the other day.  Actually merging this one
> runs into that annoying regulator framework isssue on most
> systems.
> 
> - Dave
> 
> 
> 


I have another problem:


arch/arm/mach-omap2/built-in.o: In function `twl_mmc23_set_power':
/home/ahunter/git/lo-on-rover/arch/arm/mach-omap2/mmc-twl4030.c:282: undefined reference to `mmc_regulator_set_ocr'
/home/ahunter/git/lo-on-rover/arch/arm/mach-omap2/mmc-twl4030.c:293: undefined reference to `mmc_regulator_set_ocr'
arch/arm/mach-omap2/built-in.o: In function `twl_mmc1_set_power':
/home/ahunter/git/lo-on-rover/arch/arm/mach-omap2/mmc-twl4030.c:219: undefined reference to `mmc_regulator_set_ocr'
/home/ahunter/git/lo-on-rover/arch/arm/mach-omap2/mmc-twl4030.c:235: undefined reference to `mmc_regulator_set_ocr'
arch/arm/mach-omap2/built-in.o: In function `twl_mmc_late_init':
/home/ahunter/git/lo-on-rover/arch/arm/mach-omap2/mmc-twl4030.c:128: undefined reference to `mmc_regulator_get_ocrmask'
make: *** [.tmp_vmlinux1] Error 1


The linker is not happy with built-in code trying to call functions in a module directly.