From: Adrian Hunter <adrian.hunter@nokia.com>
To: David Brownell <david-b@pacbell.net>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@sirena.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
linux-omap Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] regulator: twl4030 VAUX3 supports 3.0V
Date: Thu, 26 Mar 2009 16:21:14 +0200 [thread overview]
Message-ID: <49CB8F5A.4030400@nokia.com> (raw)
In-Reply-To: <200903251003.29340.david-b@pacbell.net>
>From 51f946af56a5de9c25b2eb6e6a33660283f84195 Mon Sep 17 00:00:00 2001
From: Adrian Hunter <adrian.hunter@nokia.com>
Date: Fri, 6 Mar 2009 14:51:30 +0200
Subject: [PATCH] regulator: twl4030 VAUX3 supports 3.0V
TWL4030 and TWL5030 support 3.0V on VAUX3.
Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com>
---
drivers/regulator/twl4030-regulator.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/twl4030-regulator.c b/drivers/regulator/twl4030-regulator.c
index f3ec98c..e2032fb 100644
--- a/drivers/regulator/twl4030-regulator.c
+++ b/drivers/regulator/twl4030-regulator.c
@@ -193,6 +193,9 @@ static int twl4030reg_set_mode(struct regulator_dev *rdev, unsigned mode)
*
* VSEL values documented as "TI cannot support these values" are flagged
* in these tables as UNSUP() values; we normally won't assign them.
+ *
+ * VAUX3 at 3V is incorrectly listed in some TI manuals as unsupported.
+ * TI are revising the twl5030/tps659x0 specs to support that 3.0V setting.
*/
#ifdef CONFIG_TWL4030_ALLOW_UNSUPPORTED
#define UNSUP_MASK 0x0000
@@ -223,7 +226,7 @@ static const u16 VAUX2_VSEL_table[] = {
};
static const u16 VAUX3_VSEL_table[] = {
1500, 1800, 2500, 2800,
- UNSUP(3000), UNSUP(3000), UNSUP(3000), UNSUP(3000),
+ 3000, 3000, 3000, 3000,
};
static const u16 VAUX4_VSEL_table[] = {
700, 1000, 1200, UNSUP(1300),
--
1.5.6.3
next prev parent reply other threads:[~2009-03-26 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 13:01 [PATCH] regulator: twl4030 VAUX3 supports 3.0V Adrian Hunter
2009-03-06 18:23 ` Liam Girdwood
2009-03-06 19:16 ` David Brownell
2009-03-06 22:18 ` Mark Brown
2009-03-06 22:48 ` David Brownell
2009-03-09 11:47 ` Liam Girdwood
2009-03-17 7:36 ` Adrian Hunter
2009-03-17 11:43 ` Liam Girdwood
2009-03-25 8:28 ` Adrian Hunter
2009-03-25 17:03 ` David Brownell
2009-03-26 14:21 ` Adrian Hunter [this message]
2009-03-31 10:43 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CB8F5A.4030400@nokia.com \
--to=adrian.hunter@nokia.com \
--cc=broonie@sirena.org.uk \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox