public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@yandex.ru>
To: "Guzman Lugo, Fernando" <x0095840@ti.com>
Cc: "Pandita, Vikram" <vikram.pandita@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/4] [OMAPZOOM] [UPDATE]DSPBRIDGE: Memory lock for DMM.
Date: Wed, 01 Apr 2009 10:25:56 +0300	[thread overview]
Message-ID: <49D31704.6020105@yandex.ru> (raw)
In-Reply-To: <496565EC904933469F292DDA3F1663E60287EF28E7@dlee06.ent.ti.com>

Guzman Lugo, Fernando wrote:
> +		patemp = pa;
> +		while (temp++ < num4KEntries) {
> +			/* FIXME: This is a hack to avoid getting pages for
> +			 *  video overlay		*/
> +			if (pfn_valid(__phys_to_pfn(patemp))) {
> +				pg = phys_to_page(patemp);
> +				get_page(pg);
> +				if (page_count(pg) <= 1) {
> +					printk(KERN_EMERG "DSPBRIDGE:MAP  "
> +						"function: COUNT 0 FOR PA "
> +						"0x%x\n", patemp);
> +					printk(KERN_EMERG "Bad page state"
> +						"in process '%s'\n"
> +						"page:%p flags:0x%0*lx "
> +						"mapping:%p mapcount:%d "
> +						"count:%d\n"
> +						"Trying to fix it up, but "
> +						"a reboot is needed\n"
> +						"Backtrace:\n",
> +						current->comm, pg,
> +						(int)(2*sizeof(unsigned long)),
> +						(unsigned long)pg->flags,
> +						pg->mapping, page_mapcount(pg),
> +						page_count(pg));
> +					dump_stack();
> +					BUG_ON(1);
> +				}
> +			}

Sorry for repeating myself, I just thought I have a good
suggestion. You could try the Obfuscated C code contest
and win some money with this code:

http://www.ioccc.org

:-)

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-04-01  7:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01  0:54 [PATCH 1/4] [OMAPZOOM] [UPDATE]DSPBRIDGE: Memory lock for DMM Guzman Lugo, Fernando
2009-04-01  7:25 ` Artem Bityutskiy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-04-07 19:26 [PATCH 1/4] [OMAPZOOM] [UPDATE] DSPBRIDGE: " Guzman Lugo, Fernando
2009-04-07 20:19 ` Ameya Palande
2009-04-07 20:27   ` Kanigeri, Hari
2009-04-07 20:49     ` Ameya Palande
2009-04-07 20:59       ` Kanigeri, Hari
2009-04-07 21:20         ` Ameya Palande
2009-04-07 21:36           ` Kanigeri, Hari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D31704.6020105@yandex.ru \
    --to=dedekind@yandex.ru \
    --cc=linux-omap@vger.kernel.org \
    --cc=vikram.pandita@ti.com \
    --cc=x0095840@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox