public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Kim Kyuwon <chammoru@gmail.com>
Cc: "Premi, Sanjeev" <premi@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Nayak, Rajendra" <rnayak@ti.com>
Subject: Re: PM branch rebased to 2.6.29... for real this time
Date: Thu, 02 Apr 2009 09:06:37 -0700	[thread overview]
Message-ID: <49D4E28D.50601@deeprootsystems.com> (raw)
In-Reply-To: <4d34a0a70904012058h62914304k3318720685b9513@mail.gmail.com>

Yes, this locking problem requires Rajendra's patchset which needs to be 
updated for the PM branch.

Kevin

Kim Kyuwon wrote:
> Hi Kevin, Sanjeev,
> 
> I'm having the same problem.
> 
> when clk_set_rate() is invoked in omap_cpu_init() as shown below:
> 
> 	clk_set_rate(mpu_clk, policy->cpuinfo.max_freq * 1000);
> 
> It acquires the clocks mutex by the next statement.
> 
> 	mutex_lock(&clocks_mutex);
> 
> But after invoking arch_clock->clk_set_rate() in the middle of
> clk_set_rate(), clock_set_rate() is invoked again. So deadlock occurs
> due to mutex_lock() in clock_set_rate().
> 
> I think setting the default governor can not help this deadlock.
> 
> Regards,
> Kyuwon
> 
> On Thu, Apr 2, 2009 at 3:46 AM, Kevin Hilman
> <khilman@deeprootsystems.com> wrote:
>> "Premi, Sanjeev" <premi@ti.com> writes:
>>
>> [...]
>>
>>>> Sounds to me like CPUfreq is changing frequencies during bootup.  Did
>>>> you select ondemand as the default CPUfreq governor?
>>> [sp] Yes. This is what I feel too. Only I was not clear why the process
>>> gets stuck at WFI. Haven't been able to debug further. So far...
>>>
>>>> If so, can you try with performance as the default governor.
>>> [sp] It was performance governor only.
>>>
>>>> If you're already using performance, then u-boot is setting a slower
>>>> speed and CPUfreq may decide to change it during boot.
>>> [sp] That is the case.
>>>
>> Can you try setting the default governor to userspace so that no DVFS
>> changes will happen during boot?
>>
>> Kevin
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> 
> 


  reply	other threads:[~2009-04-02 16:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-25 22:55 PM branch rebased to 2.6.29... for real this time Kevin Hilman
2009-03-31 14:55 ` Premi, Sanjeev
2009-04-01  5:11   ` Kevin Hilman
2009-04-01  7:18     ` Premi, Sanjeev
2009-04-01 18:46       ` Kevin Hilman
2009-04-02  3:58         ` Kim Kyuwon
2009-04-02 16:06           ` Kevin Hilman [this message]
2009-04-03  5:21             ` Nayak, Rajendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D4E28D.50601@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=chammoru@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=premi@ti.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox