From: Artem Bityutskiy <dedekind@yandex.ru>
To: Ameya Palande <ameya.palande@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH][UPDATED] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup
Date: Fri, 17 Apr 2009 18:38:52 +0300 [thread overview]
Message-ID: <49E8A28C.1020104@yandex.ru> (raw)
In-Reply-To: <1239981547-30944-1-git-send-email-ameya.palande@nokia.com>
Ameya Palande wrote:
> }
> - return status;
> + return ((int_clk_status | fun_clk_status) != DSP_SOK) ? DSP_EFAIL :
> + DSP_SOK;
> }
Side note:
Is it possible to rework the code and remove thse insane
DSP_EFAIL and DSP_SOK? Wouldn't it be possible to use
the good practices we have in kernel? Namely,
1. Return 0 on success.
2. Return negative error code on failure?
This is C, not visual basic, after all...
P.S. Ameya, do not take this as a personal attack. The
code is just so ugly and embarrassing, that I cannot stop
flaming :-)
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-04-17 15:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 12:19 [PATCH] DSPBRIDGE: CLK_Enable and CLK_Disable Code cleanup Ameya Palande
2009-04-17 13:05 ` Kanigeri, Hari
2009-04-17 14:46 ` Artem Bityutskiy
2009-04-17 15:19 ` [PATCH][UPDATED] " Ameya Palande
2009-04-17 15:38 ` Artem Bityutskiy [this message]
2009-04-17 16:17 ` [PATCH][Take 2] " Ameya Palande
2009-04-17 15:49 ` [PATCH][UPDATED] " Artem Bityutskiy
2009-04-17 17:45 ` Ramirez Luna, Omar
2009-04-17 19:31 ` Kanigeri, Hari
2009-04-25 11:42 ` Felipe Contreras
2009-04-25 13:07 ` Nishanth Menon
2009-04-25 13:19 ` Ramirez Luna, Omar
2009-04-25 14:47 ` Koen Kooi
2009-05-14 18:00 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E8A28C.1020104@yandex.ru \
--to=dedekind@yandex.ru \
--cc=ameya.palande@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox