From: Kim Kyuwon <q1.kim@samsung.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-omap@vger.kernel.org
Subject: Re: [PATCH 01/13] Revert "ARM: OMAP: Mask interrupts when disabling interrupts, v2"
Date: Fri, 22 May 2009 08:38:01 +0900 [thread overview]
Message-ID: <4A15E5D9.7090704@samsung.com> (raw)
In-Reply-To: <1242861576-13008-2-git-send-email-khilman@deeprootsystems.com>
Kevin Hilman wrote:
> This reverts commit 5461af5af5c6a7fee78978aafe720541bf3a2f55.
>
> Adding a disable hook to the irq_chip is not the way to fix the
> problem being addressed by this patch. Instead, we need to fix
> support for [enable|disable]_irq_wake().
Agree with you if we can use disable_irq_wake for MPU Interrupt with not
masking the IRQ. Can you explain how we can fix support for
disable_irq_wake() for omap_irq_chip?
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> arch/arm/mach-omap2/irq.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> index 998c5c4..08a3b99 100644
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -134,7 +134,6 @@ static struct irq_chip omap_irq_chip = {
> .ack = omap_mask_ack_irq,
> .mask = omap_mask_irq,
> .unmask = omap_unmask_irq,
> - .disable = omap_mask_irq,
> };
>
> static void __init omap_irq_bank_init_one(struct omap_irq_bank *bank)
next prev parent reply other threads:[~2009-05-21 23:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 23:19 [PATCH v2 00/13] OMAP2/3: PM sync-up Kevin Hilman
2009-05-20 23:19 ` [PATCH 01/13] Revert "ARM: OMAP: Mask interrupts when disabling interrupts, v2" Kevin Hilman
2009-05-20 23:19 ` [PATCH 02/13] OMAP2/3: PM: push core PM code from linux-omap Kevin Hilman
2009-05-20 23:19 ` [PATCH 03/13] OMAP: Add new function to check wether there is irq pending Kevin Hilman
2009-05-20 23:19 ` [PATCH 04/13] OMAP3: PM: Force IVA2 into idle during bootup Kevin Hilman
2009-05-20 23:19 ` [PATCH 05/13] OMAP3: PM: Add wake-up bit defintiions for CONTROL_PADCONF_X Kevin Hilman
2009-05-20 23:19 ` [PATCH 06/13] OMAP3: PM: UART: disable clocks when idle and off-mode support Kevin Hilman
2009-05-20 23:19 ` [PATCH 07/13] OMAP: UART: Add sysfs interface for adjusting UART sleep timeout Kevin Hilman
2009-05-20 23:19 ` [PATCH 08/13] OMAP3: PM: Add D2D clocks and auto-idle setup to PRCM init Kevin Hilman
2009-05-20 23:19 ` [PATCH 09/13] OMAP3: PM: D2D clockdomain supports SW supervised transitions Kevin Hilman
2009-05-20 23:19 ` [PATCH 10/13] OMAP3: PM: Ensure MUSB block can idle when driver not loaded Kevin Hilman
2009-05-20 23:19 ` [PATCH 11/13] OMAP3: PM: Ensure PRCM interrupts are cleared at boot Kevin Hilman
2009-05-20 23:19 ` [PATCH 12/13] OMAP3: PM: Clear pending PRCM reset flags on init Kevin Hilman
2009-05-20 23:19 ` [PATCH 13/13] OMAP3: PM: prevent module wakeups from waking IVA2 Kevin Hilman
2009-05-28 15:48 ` [PATCH 02/13] OMAP2/3: PM: push core PM code from linux-omap Russell King - ARM Linux
2009-05-28 16:51 ` Kevin Hilman
2009-05-28 18:22 ` Kevin Hilman
2009-05-21 23:38 ` Kim Kyuwon [this message]
2009-05-22 14:54 ` [PATCH 01/13] Revert "ARM: OMAP: Mask interrupts when disabling interrupts, v2" Kevin Hilman
2009-05-22 15:51 ` Kim Kyuwon
2009-05-22 18:16 ` Kevin Hilman
2009-05-22 22:59 ` Kim Kyuwon
2009-05-25 5:33 ` Kim Kyuwon
2009-05-22 23:22 ` Russell King - ARM Linux
2009-05-23 0:47 ` Kim Kyuwon
2009-05-26 23:12 ` [PATCH v2 00/13] OMAP2/3: PM sync-up Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A15E5D9.7090704@samsung.com \
--to=q1.kim@samsung.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox