RE: [PATCH 6/7] omap4: Workaround for CMD line reset.

["Madhusudhan" <madhu.cr@ti.com>]

> -----Original Message-----
> From: kishore kadiyala [mailto:kishorek.kadiyala@gmail.com]
> Sent: Tuesday, September 14, 2010 10:47 AM
> To: Madhusudhan Chikkature; Santosh Shilimkar
> Cc: linux-omap@vger.kernel.org; tony@atomide.com;
> khilman@deeprootsystems.com
> Subject: Re: [PATCH 6/7] omap4: Workaround for CMD line reset.
> 
> Hi Madhu,
> 
> On Thu, Sep 9, 2010 at 4:53 PM, Santosh Shilimkar
> <santosh.shilimkar@ti.com> wrote:
> > From: Madhusudhan Chikkature <madhu.cr@ti.com>
> >
> > Add a delay after CMD line reset to accomdate the reset to complete.
> > The SYSCTL seems to reflect SRC immediately which might not really
> > be indicating the complete of reset. This is observed only with ES2.0
> > silicon
> >
> > Signed-off-by: Madhusudhan Chikkature <madhu.cr@ti.com>
> > ---
> >  drivers/mmc/host/omap_hsmmc.c |    8 ++++++++
> >  1 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/mmc/host/omap_hsmmc.c
> b/drivers/mmc/host/omap_hsmmc.c
> > index 4a8776f..1c359f0 100644
> > --- a/drivers/mmc/host/omap_hsmmc.c
> > +++ b/drivers/mmc/host/omap_hsmmc.c
> > @@ -986,6 +986,14 @@ static inline void
> omap_hsmmc_reset_controller_fsm(struct omap_hsmmc_host *host,
> >                (i++ < limit))
> >                cpu_relax();
> >
> > +       /*
> > +        * On OMAP4 ES2 the SRC is zero in the first loop itself
> strangely
> > +        * vs on ES1 it takes some time.
> > +        * Could be a an issue on ES2 to indicate reset complete even
> before
> > +        * it is complete.
> > +        */
> > +       udelay(500);
> 
> Since the above work around is applicable only for OMAP4 ES2 ,
> shouldn't this udelay be avoided for other OMAP versions
> 
I did not post this to Linux omap at all. What patch are you talking about?

Regards,
Madhu

> Regards,
> Kishore
> > +
> >        if (OMAP_HSMMC_READ(host->base, SYSCTL) & bit)
> >                dev_err(mmc_dev(host->mmc),
> >                        "Timeout waiting on controller reset in %s\n",
> > --
> > 1.6.0.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html