public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Ville Tervo <ville.tervo@nokia.com>
To: ext Tony Lindgren <tony@atomide.com>
Cc: Andrew de Quincey <adq_dvb@lidskialf.net>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [patch] Fix brf6510 cleanup code
Date: Mon, 15 Jun 2009 11:38:47 +0300	[thread overview]
Message-ID: <4A360897.1050701@nokia.com> (raw)
In-Reply-To: <20090615080242.GD4474@atomide.com>

Hi Andrew,

ext Tony Lindgren wrote:
> * Andrew de Quincey <adq_dvb@lidskialf.net> [090608 13:04]:
>> The brf6150 driver is missing several necessary cleanup steps to allow  
>> module unloading. Add them.

Yes. This driver was used as compiled in driver and seems to be missing 
cleanups.

As you may have noticed this brf6150 driver has been replaced by hci_h4p 
drier in later tablets and the easiest way to maintain support for Nokia 
770 bluetooth would be to make sure that also brf6150 works with the 
current driver. AFAIK it should work with quite little modifications. 
The settings negotiation is a little bit different.

> 
> I've removed the brf6150 from linux-omap as this should get merged into
> the mainline kernel via bt list.
> 
> Ville & Andrew, can you guys please coordinate on the bt list to get
> the driver merged in? I believe there were some changes needed for
> passing the hw address as a module option and for loading the firmware
> or something..

Is 2.6.30 booting in Nokia 770/N800/N810? If so then I guess this should 
be quite easy task.

-- 
Ville

  reply	other threads:[~2009-06-15  8:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-30 17:07 prepatch: Fix brf6510 cleanup code Andrew de Quincey
2009-06-08 20:03 ` [patch] " Andrew de Quincey
2009-06-15  8:02   ` Tony Lindgren
2009-06-15  8:38     ` Ville Tervo [this message]
2009-06-15  8:58       ` Tony Lindgren
2009-06-15  9:53         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A360897.1050701@nokia.com \
    --to=ville.tervo@nokia.com \
    --cc=adq_dvb@lidskialf.net \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox