Re: [PATCH 2:2][MTD][NAND]omap : Adding DMA mode support in nand prefetch/post-write

From: Artem Bityutskiy <dedekind1@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	david-b@pacbell.net, Tony Lindgren <tony@atomide.com>,
	linux-mtd@lists.infradead.org, vimal singh <vimalsingh@ti.com>
Subject: Re: [PATCH 2:2][MTD][NAND]omap : Adding DMA mode support in nand prefetch/post-write
Date: Fri, 10 Jul 2009 15:44:26 +0300	[thread overview]
Message-ID: <4A5737AA.7050208@gmail.com> (raw)
In-Reply-To: <1247229621.29541.4.camel@macbook.infradead.org>

David Woodhouse wrote:
> On Fri, 2009-07-10 at 15:02 +0300, Artem Bityutskiy wrote:
>> On Fri, 2009-07-10 at 17:25 +0530, vimal singh wrote:
>>> +	/* The fifo depth is 64 bytes. We have a sync at each frame and frame
>>> +	 * length is 64 bytes.
>>> +	 */
>>> +	int buf_len = len/64;
>> To optimize performance it is better not to rely on gcc and use <<
> 
> If you ever see gcc screwing up division of an 'int' by a constant 64,
> file a GCC bug.

I did see gcc generated division instruction instead of shift
instruction on x86 when the kernel is compiles with size optimization.
I think this is because it division instruction is shorter.

The exact place I we saw was the UBIFS binary search function, and
division by 2 was not compiled into a shift instruction.

So what I suggested is to use shift explicitly if this is wanted.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/