Re: [PATCH 1/4] DSPBRIDGE: Fix macros that break when inside an if/else

[Ameya Palande <ameya.palande@nokia.com>]

ext Menon, Nishanth wrote:
> Phil,
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>> owner@vger.kernel.org] On Behalf Of Phil Carmody
>> Sent: Tuesday, July 14, 2009 6:03 AM
>>
>> On Fri, 2009-07-10 at 01:51 +0200, ext Guzman Lugo, Fernando wrote:
>>> Thanks for the patch, it only has indentation problems, this is the
>> checkpatch output:
>>> WARNING: suspect code indent for conditional statements (8, 12)
>>> #34: FILE: drivers/dsp/bridge/pmgr/wcd.c:152:
>>> +       if (DSP_SUCCEEDED(status)) {                    \
>>> +           if (unlikely((src) == NULL) ||              \
>>>
>>> WARNING: line over 80 characters
>>> #36: FILE: drivers/dsp/bridge/pmgr/wcd.c:154:
>>> +               unlikely(copy_from_user(dest, src, (elements) *
>> sizeof(*(dest))))) { \
>>> WARNING: suspect code indent for conditional statements (8, 12)
>>> #46: FILE: drivers/dsp/bridge/pmgr/wcd.c:164:
>>> +       if (DSP_SUCCEEDED(status)) {                    \
>>> +           if (unlikely((dest) == NULL) ||
>> \
>>> WARNING: line over 80 characters
>>> #48: FILE: drivers/dsp/bridge/pmgr/wcd.c:166:
>>> +               unlikely(copy_to_user(dest, src, (elements) *
>> sizeof(*(src))))) { \
>>> total: 0 errors, 4 warnings, 48 lines checked
>>>
>>> Could you please fix that warning please?
>> I suspect the only way to fix those warnings would either introduce
>> other warnings, or \
> Gentle query: Have we already tried this or is it just a suspicion?
> 
> 
>> 							would \
>> 							lead \
>> 							to \
>> 							utterly \
>> 							unread- \
>> 							able \
>> 							code.
>>
>> If you check how and why the original TI-originated version of the code
>> does not follow the linux coding standards, the difficulties we would
>> have making a warning-free patch of it should be apparent.
> 
> Past is past. The idea was not to introduce anymore warning code.

I agree but if you want to stick to this, then I don't think we can get a
readable macro. And I personally prefer readability over warnings generated by
checkpatch.pl script.

Cheers,
Ameya.