public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
To: Jarkko Nikula <jhnikula@gmail.com>,
	Arun K S <arunks@mistralsolutions.com>
Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	alsa-devel@alsa-project.org,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	e3-hacking@earth.li
Subject: Re: [RFC] [PATCH] ASoC: OMAP: full duplex mode fix
Date: Mon, 03 Aug 2009 16:00:32 +0200	[thread overview]
Message-ID: <4A76ED80.6040001@tis.icnet.pl> (raw)
In-Reply-To: <20090803112950.3fb6cda9.jhnikula@gmail.com>

Jarkko Nikula wrote:
> On Mon, 3 Aug 2009 03:32:04 +0200
> Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:
> 
>> This patch tries to correct the problem of full duplex mode not working
>> over a single McBSP based CPU DAI.
>>
>> Created against linux-2.6.31-rc5.
>> Tested on Amstrad Delta.
>>
> Do you have some specific test case how to trigger this? I haven't
> seen this on 2420 or 34xx (e.g. with 'arecord -d 1 -f dat |aplay') but
> I have no doubt that this can happen on 1510. At least this doesn't
> cause any harm on Beagle so I'm fine with the fix.

Hi,
I made more testing on my OMAP1510 and found out that I could get your 
example usage working without my patch, but only if started like this:

	arecord -D hw:0,0 -f S16_LE|aplay -D hw:0,0

If I start the same with "-D hw:0,0" omitted from aplay, it doesn't work 
any longer, waiting forever. It definitelly doesn't work if I start 
capture and playback one after another, no matter which one goes first 
(record while playing or play while recording). So it looks like 
starting both streams simultaneously can do the job, but a short delay 
breaks it.

With my patch, it seems to work fine for me in all cases.

Jarkko, have you ever tried it on your OMAP2/3 with parallel playback 
and capture started one after another, not simultaneously?

Arun, can your snd-soc-osk9512 work on OMAP1610 in full duplex mode 
without any limitations?

If the problem appears to be OMAP1510 or AMS_DELTA specific, I can add a 
check for a machine or cpu type to avoid braking unaffected machines.

Thanks,
Janusz


  parent reply	other threads:[~2009-08-03 14:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03  1:32 [RFC] [PATCH] ASoC: OMAP: full duplex mode fix Janusz Krzysztofik
2009-08-03  8:29 ` Jarkko Nikula
2009-08-03  9:43   ` Mark Brown
2009-08-03 14:00   ` Janusz Krzysztofik [this message]
2009-08-03 15:14     ` Jarkko Nikula
2009-08-04 20:46       ` Janusz Krzysztofik
2009-08-05  6:45         ` Peter Ujfalusi
2009-08-05 13:14           ` Janusz Krzysztofik
2009-08-06  9:30           ` Janusz Krzysztofik
2009-08-05  7:21         ` Jarkko Nikula
2009-08-05  8:42           ` Jarkko Nikula
2009-08-05 13:26             ` Janusz Krzysztofik
2009-08-06  0:27               ` Janusz Krzysztofik
2009-08-06  9:16             ` Janusz Krzysztofik
2009-08-03 17:53     ` Arun KS
2009-08-03 17:57       ` Arun KS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A76ED80.6040001@tis.icnet.pl \
    --to=jkrzyszt@tis.icnet.pl \
    --cc=alsa-devel@alsa-project.org \
    --cc=arunks@mistralsolutions.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=e3-hacking@earth.li \
    --cc=jhnikula@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox