From: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org, Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Arun K S <arunks@mistralsolutions.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [RFC] [PATCH] ASoC: OMAP: full duplex mode fix
Date: Wed, 05 Aug 2009 15:26:47 +0200 [thread overview]
Message-ID: <4A798897.5000904@tis.icnet.pl> (raw)
In-Reply-To: <20090805114254.02e3d0e2.jhnikula@gmail.com>
Jarkko Nikula wrote:
> On Wed, 5 Aug 2009 10:21:49 +0300
> Jarkko Nikula <jhnikula@gmail.com> wrote:
>
>>> If my analysis is correct, the best solution I can see would be starting McBSP
>>> transfer for one direction only, not both, so the opposite direction can be
>>> started when needed. That requires deeper and wider OMAP knowledge and a
>>> change in omap_mcbsp_start() API though. I am not in a position to deal with
>>> this myself, I'm afraid.
>>>
>> I favor this change. Actually I remember I was thinking shortly to
>> change API of omap_mcbsp_start and _stop more than year back or so but
>> didn't find it necessary back then.
>>
>> I think change will be trivial. Basically two new arguments indicating
>> are the TX/RX active and let the first/last caller to deal with
>> sample-rate generator and frame sync activation/de-activation.
>>
> I hacked a patch below. Can you test does it help?
Will do tonight (CET).
Now seeing how easy it was (for you ;), I think I could try to follow
that way an modify omap_mcbsp_config() in the same spirit, if you find
it of any use.
Cheers,
Janusz
next prev parent reply other threads:[~2009-08-05 13:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 1:32 [RFC] [PATCH] ASoC: OMAP: full duplex mode fix Janusz Krzysztofik
2009-08-03 8:29 ` Jarkko Nikula
2009-08-03 9:43 ` Mark Brown
2009-08-03 14:00 ` Janusz Krzysztofik
2009-08-03 15:14 ` Jarkko Nikula
2009-08-04 20:46 ` Janusz Krzysztofik
2009-08-05 6:45 ` Peter Ujfalusi
2009-08-05 13:14 ` Janusz Krzysztofik
2009-08-06 9:30 ` Janusz Krzysztofik
2009-08-05 7:21 ` Jarkko Nikula
2009-08-05 8:42 ` Jarkko Nikula
2009-08-05 13:26 ` Janusz Krzysztofik [this message]
2009-08-06 0:27 ` Janusz Krzysztofik
2009-08-06 9:16 ` Janusz Krzysztofik
2009-08-03 17:53 ` Arun KS
2009-08-03 17:57 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A798897.5000904@tis.icnet.pl \
--to=jkrzyszt@tis.icnet.pl \
--cc=alsa-devel@alsa-project.org \
--cc=arunks@mistralsolutions.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox