Re: [PATCH] Runtime detection of Si features

[Nishanth Menon <nm@ti.com>]

Kevin Hilman had written, on 08/13/2009 11:13 AM, the following:
> Sanjeev Premi <premi@ti.com> writes:
> 
>> The OMAP35x family has multiple variants differing
>> in the HW features. This patch detects these features
>> at runtime and prints information during the boot.
>>
>> Since most of the code seemed repetitive, macros
>> have been used for readability.
>>
>> Signed-off-by: Sanjeev Premi <premi@ti.com>
> 
> I like the feature-based approach.
> 
> A couple questions though.  Is there a bit/register that reports the
> collapsed powerdomains of the devices with modified PRCM?
> 
> Also, how will other code query the features?  You're currently
> exporting the omap_has_*() functions, but there are no prototypes.
> 
> I think I'd rather see a static inline functions in <mach/cpu.h>
> for checking features.  Comments to that end inlined below...
Wonder if we can setup some sort of infrastructure for:
a) features
b) erratas
linked to OMAP revs + even better w.r.t silicon module(SGX,I2c) 
revisions since at times they are used across multiple OMAPs?

-- 
Regards,
Nishanth Menon