From mboxrd@z Thu Jan 1 00:00:00 1970 From: Angelo Arrifano Subject: Re: [APPLIED] [PATCH] omapfb: Reorder Register_framebuffer call Date: Tue, 22 Sep 2009 18:21:44 +0100 Message-ID: <4AB907A8.8040805@gmail.com> References: <1252773249-24444-1-git-send-email-saaguirre@ti.com> <4de7f8a60909220759g63b592eek85a2bca04b264d2e@mail.gmail.com> <20090922162853.GC14890@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ey-out-2122.google.com ([74.125.78.25]:11605 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbZIVRPm (ORCPT ); Tue, 22 Sep 2009 13:15:42 -0400 Received: by ey-out-2122.google.com with SMTP id d26so641705eyd.19 for ; Tue, 22 Sep 2009 10:15:45 -0700 (PDT) In-Reply-To: <20090922162853.GC14890@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Alistair Buxton , linux-omap@vger.kernel.org Tony Lindgren wrote: > * Jan Blunck [090922 07:59]: >> On Tue, Sep 22, 2009 at 3:31 AM, Tony Lindgren wrote: >>> This patch has been applied to the linux-omap >>> by youw fwiendly patch wobot. >>> >>> Branch in linux-omap: omap-fixes >>> >>> Initial commit ID (Likely to change): 9aef1066fb5ca8506068eaab1c552ecca4c85475 >>> >>> PatchWorks >>> http://patchwork.kernel.org/patch/47089/ >>> > > Added back the original Cc's that were dropped from the linux-omap > commit message. > >> Is it actually safe to do this? The framebuffer can be used directly >> after it is registered. In this case it would mean it is used before >> it is even fully initialized (set_fb_var(), set_fb_fix(), ... are >> being called). > > Good point, dropping the patch. > > Also, let's let Tomi Valkeinen deal with queueing up the omap fb code. > I can then merge Tomi's branck into linux-omap master branch as needed. > > Regards, > > Tony Hello, This patch doesn't work for us at linwizard project (omap850). The commit 537a1bf059fa312355696fa6db80726e655e7f17 makes the HTC Wizard crash at boot due to usage of uninitialized mutex. Applying the referred patch prevents the crash but the LCD screen goes black and doesn't show any data. - Angelo