* Re: [PATCH] OMAP: PM: Export functions from OMAP NOOP PM interface
2009-09-22 15:54 [PATCH] OMAP: PM: Export functions from OMAP NOOP PM interface Ameya Palande
@ 2009-09-28 8:25 ` Ameya Palande
2009-09-30 18:46 ` Kevin Hilman
2009-10-14 22:16 ` Kevin Hilman
2 siblings, 0 replies; 4+ messages in thread
From: Ameya Palande @ 2009-09-28 8:25 UTC (permalink / raw)
To: linux-omap@vger.kernel.org; +Cc: khilman@deeprootsystems.com, paul@pwsan.com
Palande Ameya (Nokia-D/Helsinki) wrote:
> Without this patch, a driver which uses these symbols will break when user
> selects NOOP PM interface.
>
> Signed-off-by: Ameya Palande <ameya.palande@nokia.com>
> ---
> arch/arm/plat-omap/omap-pm-noop.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/omap-pm-noop.c b/arch/arm/plat-omap/omap-pm-noop.c
> index 3b075de..10463a4 100644
> --- a/arch/arm/plat-omap/omap-pm-noop.c
> +++ b/arch/arm/plat-omap/omap-pm-noop.c
> @@ -157,6 +157,7 @@ const struct omap_opp *omap_pm_dsp_get_opp_table(void)
>
> return NULL;
> }
> +EXPORT_SYMBOL(omap_pm_dsp_get_opp_table);
>
> void omap_pm_dsp_set_min_opp(u8 opp_id)
> {
> @@ -181,7 +182,7 @@ void omap_pm_dsp_set_min_opp(u8 opp_id)
> *
> */
> }
> -
> +EXPORT_SYMBOL(omap_pm_dsp_set_min_opp);
>
> u8 omap_pm_dsp_get_opp(void)
> {
> @@ -197,6 +198,7 @@ u8 omap_pm_dsp_get_opp(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_dsp_get_opp);
>
> u8 omap_pm_vdd1_get_opp(void)
> {
> @@ -208,6 +210,7 @@ u8 omap_pm_vdd1_get_opp(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_vdd1_get_opp);
>
> u8 omap_pm_vdd2_get_opp(void)
> {
> @@ -219,6 +222,7 @@ u8 omap_pm_vdd2_get_opp(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_vdd2_get_opp);
>
> /*
> * CPUFreq-originated constraint
> @@ -259,6 +263,7 @@ void omap_pm_cpu_set_freq(unsigned long f)
> * CDP should just be able to set the VDD1 OPP clock rate here.
> */
> }
> +EXPORT_SYMBOL(omap_pm_cpu_set_freq);
>
> unsigned long omap_pm_cpu_get_freq(void)
> {
> @@ -270,6 +275,7 @@ unsigned long omap_pm_cpu_get_freq(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_cpu_get_freq);
>
> /*
> * Device context loss tracking
Hi Paul/Kevin,
Any update/comments about this patch?
Cheers,
Ameya.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] OMAP: PM: Export functions from OMAP NOOP PM interface
2009-09-22 15:54 [PATCH] OMAP: PM: Export functions from OMAP NOOP PM interface Ameya Palande
2009-09-28 8:25 ` Ameya Palande
@ 2009-09-30 18:46 ` Kevin Hilman
2009-10-14 22:16 ` Kevin Hilman
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2009-09-30 18:46 UTC (permalink / raw)
To: Ameya Palande; +Cc: linux-omap, paul
Ameya Palande <ameya.palande@nokia.com> writes:
> Without this patch, a driver which uses these symbols will break when user
> selects NOOP PM interface.
>
> Signed-off-by: Ameya Palande <ameya.palande@nokia.com>
Thanks, applying to PM branch.
Kevin
> ---
> arch/arm/plat-omap/omap-pm-noop.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/omap-pm-noop.c b/arch/arm/plat-omap/omap-pm-noop.c
> index 3b075de..10463a4 100644
> --- a/arch/arm/plat-omap/omap-pm-noop.c
> +++ b/arch/arm/plat-omap/omap-pm-noop.c
> @@ -157,6 +157,7 @@ const struct omap_opp *omap_pm_dsp_get_opp_table(void)
>
> return NULL;
> }
> +EXPORT_SYMBOL(omap_pm_dsp_get_opp_table);
>
> void omap_pm_dsp_set_min_opp(u8 opp_id)
> {
> @@ -181,7 +182,7 @@ void omap_pm_dsp_set_min_opp(u8 opp_id)
> *
> */
> }
> -
> +EXPORT_SYMBOL(omap_pm_dsp_set_min_opp);
>
> u8 omap_pm_dsp_get_opp(void)
> {
> @@ -197,6 +198,7 @@ u8 omap_pm_dsp_get_opp(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_dsp_get_opp);
>
> u8 omap_pm_vdd1_get_opp(void)
> {
> @@ -208,6 +210,7 @@ u8 omap_pm_vdd1_get_opp(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_vdd1_get_opp);
>
> u8 omap_pm_vdd2_get_opp(void)
> {
> @@ -219,6 +222,7 @@ u8 omap_pm_vdd2_get_opp(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_vdd2_get_opp);
>
> /*
> * CPUFreq-originated constraint
> @@ -259,6 +263,7 @@ void omap_pm_cpu_set_freq(unsigned long f)
> * CDP should just be able to set the VDD1 OPP clock rate here.
> */
> }
> +EXPORT_SYMBOL(omap_pm_cpu_set_freq);
>
> unsigned long omap_pm_cpu_get_freq(void)
> {
> @@ -270,6 +275,7 @@ unsigned long omap_pm_cpu_get_freq(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_cpu_get_freq);
>
> /*
> * Device context loss tracking
> --
> 1.6.2.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] OMAP: PM: Export functions from OMAP NOOP PM interface
2009-09-22 15:54 [PATCH] OMAP: PM: Export functions from OMAP NOOP PM interface Ameya Palande
2009-09-28 8:25 ` Ameya Palande
2009-09-30 18:46 ` Kevin Hilman
@ 2009-10-14 22:16 ` Kevin Hilman
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2009-10-14 22:16 UTC (permalink / raw)
To: Ameya Palande; +Cc: linux-omap, paul
Ameya Palande <ameya.palande@nokia.com> writes:
> Without this patch, a driver which uses these symbols will break when user
> selects NOOP PM interface.
>
> Signed-off-by: Ameya Palande <ameya.palande@nokia.com>
I initially pulled this into the PM branch but will now be dropping
it.
Drivers should not be calling these functions directly, but rather using
hooks in pdata as described in Documentation/arm/OMAP/omap_pm.
Kevin
> ---
> arch/arm/plat-omap/omap-pm-noop.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/omap-pm-noop.c b/arch/arm/plat-omap/omap-pm-noop.c
> index 3b075de..10463a4 100644
> --- a/arch/arm/plat-omap/omap-pm-noop.c
> +++ b/arch/arm/plat-omap/omap-pm-noop.c
> @@ -157,6 +157,7 @@ const struct omap_opp *omap_pm_dsp_get_opp_table(void)
>
> return NULL;
> }
> +EXPORT_SYMBOL(omap_pm_dsp_get_opp_table);
>
> void omap_pm_dsp_set_min_opp(u8 opp_id)
> {
> @@ -181,7 +182,7 @@ void omap_pm_dsp_set_min_opp(u8 opp_id)
> *
> */
> }
> -
> +EXPORT_SYMBOL(omap_pm_dsp_set_min_opp);
>
> u8 omap_pm_dsp_get_opp(void)
> {
> @@ -197,6 +198,7 @@ u8 omap_pm_dsp_get_opp(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_dsp_get_opp);
>
> u8 omap_pm_vdd1_get_opp(void)
> {
> @@ -208,6 +210,7 @@ u8 omap_pm_vdd1_get_opp(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_vdd1_get_opp);
>
> u8 omap_pm_vdd2_get_opp(void)
> {
> @@ -219,6 +222,7 @@ u8 omap_pm_vdd2_get_opp(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_vdd2_get_opp);
>
> /*
> * CPUFreq-originated constraint
> @@ -259,6 +263,7 @@ void omap_pm_cpu_set_freq(unsigned long f)
> * CDP should just be able to set the VDD1 OPP clock rate here.
> */
> }
> +EXPORT_SYMBOL(omap_pm_cpu_set_freq);
>
> unsigned long omap_pm_cpu_get_freq(void)
> {
> @@ -270,6 +275,7 @@ unsigned long omap_pm_cpu_get_freq(void)
>
> return 0;
> }
> +EXPORT_SYMBOL(omap_pm_cpu_get_freq);
>
> /*
> * Device context loss tracking
> --
> 1.6.2.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread