public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <ext-roger.quadros@nokia.com>
To: "tony@atomide.com" <tony@atomide.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2] omap_hsmmc: Add missing probe handler hook
Date: Fri, 02 Oct 2009 15:26:46 +0300	[thread overview]
Message-ID: <4AC5F186.9010007@nokia.com> (raw)
In-Reply-To: <1254486160-7117-1-git-send-email-ext-roger.quadros@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Quadros Roger (EXT-Teleca/Helsinki) wrote:
> The missing probe handler hook will never probe the driver. Add it back.
> Fixes broken MMC on OMAP.
> 
> We use platform_driver_probe() API since omap_hsmmc is not a hot-pluggable
> device.
> 
> Signed-off-by: Roger Quadros <ext-roger.quadros@nokia.com>
> ---
>  drivers/mmc/host/omap_hsmmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 4487cc0..0aecaae 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
>  static int __init omap_hsmmc_init(void)
>  {
>  	/* Register the MMC driver */
> -	return platform_driver_register(&omap_hsmmc_driver);
> +	return platform_driver_probe(&omap_hsmmc_driver, omap_hsmmc_probe);
>  }
>  
>  static void __exit omap_hsmmc_cleanup(void)

Tony,

  Since you've already applied my earlier patch (v1), you may used the attached 
version instead. The attached patch will apply on current head with commit id

30e0c4a059d83886690381222e14f35540c7f017

cheers,
-roger

[-- Attachment #2: 0001-omap_hsmmc-Use-platform_driver_probe-instead-of-p.patch.gz --]
[-- Type: application/x-gzip, Size: 667 bytes --]

  reply	other threads:[~2009-10-02 12:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02 12:22 [PATCH v2] omap_hsmmc: Add missing probe handler hook Roger Quadros
2009-10-02 12:26 ` Roger Quadros [this message]
2009-10-02 21:38   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC5F186.9010007@nokia.com \
    --to=ext-roger.quadros@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox