[PATCH v2] omap_hsmmc: Add missing probe handler hook

[PATCH v2] omap_hsmmc: Add missing probe handler hook

[Roger Quadros]

The missing probe handler hook will never probe the driver. Add it back.
Fixes broken MMC on OMAP.

We use platform_driver_probe() API since omap_hsmmc is not a hot-pluggable
device.

Signed-off-by: Roger Quadros <ext-roger.quadros@nokia.com>
---
 drivers/mmc/host/omap_hsmmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 4487cc0..0aecaae 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
 static int __init omap_hsmmc_init(void)
 {
 	/* Register the MMC driver */
-	return platform_driver_register(&omap_hsmmc_driver);
+	return platform_driver_probe(&omap_hsmmc_driver, omap_hsmmc_probe);
 }
 
 static void __exit omap_hsmmc_cleanup(void)
-- 
1.6.0.4

Re: [PATCH v2] omap_hsmmc: Add missing probe handler hook

[Roger Quadros]

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Quadros Roger (EXT-Teleca/Helsinki) wrote:
> The missing probe handler hook will never probe the driver. Add it back.
> Fixes broken MMC on OMAP.
> 
> We use platform_driver_probe() API since omap_hsmmc is not a hot-pluggable
> device.
> 
> Signed-off-by: Roger Quadros <ext-roger.quadros@nokia.com>
> ---
>  drivers/mmc/host/omap_hsmmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 4487cc0..0aecaae 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
>  static int __init omap_hsmmc_init(void)
>  {
>  	/* Register the MMC driver */
> -	return platform_driver_register(&omap_hsmmc_driver);
> +	return platform_driver_probe(&omap_hsmmc_driver, omap_hsmmc_probe);
>  }
>  
>  static void __exit omap_hsmmc_cleanup(void)

Tony,

  Since you've already applied my earlier patch (v1), you may used the attached 
version instead. The attached patch will apply on current head with commit id

30e0c4a059d83886690381222e14f35540c7f017

cheers,
-roger

[-- Attachment #2: 0001-omap_hsmmc-Use-platform_driver_probe-instead-of-p.patch.gz --]
[-- Type: application/x-gzip, Size: 667 bytes --]

Re: [PATCH v2] omap_hsmmc: Add missing probe handler hook

[Tony Lindgren]

* Roger Quadros <ext-roger.quadros@nokia.com> [091002 05:27]:
> Quadros Roger (EXT-Teleca/Helsinki) wrote:
>> The missing probe handler hook will never probe the driver. Add it back.
>> Fixes broken MMC on OMAP.
>>
>> We use platform_driver_probe() API since omap_hsmmc is not a hot-pluggable
>> device.
>>
>> Signed-off-by: Roger Quadros <ext-roger.quadros@nokia.com>
>> ---
>>  drivers/mmc/host/omap_hsmmc.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
>> index 4487cc0..0aecaae 100644
>> --- a/drivers/mmc/host/omap_hsmmc.c
>> +++ b/drivers/mmc/host/omap_hsmmc.c
>> @@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
>>  static int __init omap_hsmmc_init(void)
>>  {
>>  	/* Register the MMC driver */
>> -	return platform_driver_register(&omap_hsmmc_driver);
>> +	return platform_driver_probe(&omap_hsmmc_driver, omap_hsmmc_probe);
>>  }
>>   static void __exit omap_hsmmc_cleanup(void)
>
> Tony,
>
>  Since you've already applied my earlier patch (v1), you may used the 
> attached version instead. The attached patch will apply on current head 
> with commit id
>
> 30e0c4a059d83886690381222e14f35540c7f017

Thanks, will update in omap-fixes-testing.

Tony