From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 02/28] OMAP3: PM: GPIO context save/restore Date: Sat, 03 Oct 2009 09:53:19 -0500 Message-ID: <4AC7655F.6080604@gmail.com> References: <1254441538-9257-1-git-send-email-khilman@deeprootsystems.com> <1254441538-9257-2-git-send-email-khilman@deeprootsystems.com> <1254441538-9257-3-git-send-email-khilman@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yx0-f199.google.com ([209.85.210.199]:55233 "EHLO mail-yx0-f199.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754602AbZJCOxw (ORCPT ); Sat, 3 Oct 2009 10:53:52 -0400 Received: by yxe37 with SMTP id 37so1917718yxe.33 for ; Sat, 03 Oct 2009 07:53:15 -0700 (PDT) In-Reply-To: <1254441538-9257-3-git-send-email-khilman@deeprootsystems.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: linux-omap@vger.kernel.org, Rajendra Nayak Kevin Hilman said the following on 10/01/2009 06:58 PM: > From: Rajendra Nayak > > Signed-off-by: Rajendra Nayak > --- > arch/arm/plat-omap/gpio.c | 92 ++++++++++++++++++++++++++++++++ > arch/arm/plat-omap/include/mach/gpio.h | 3 +- > 2 files changed, 94 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c > index b0c7361..9850ade 100644 > --- a/arch/arm/plat-omap/gpio.c > +++ b/arch/arm/plat-omap/gpio.c > + > +/* restore the required registers of bank 2-6 */ > +void omap3_gpio_restore_context(void) > +{ > + int i; > + for (i = 1; i < gpio_bank_count; i++) { > + struct gpio_bank *bank = &gpio_bank[i]; > + __raw_writel(gpio_context[i].sysconfig, > + bank->base + OMAP24XX_GPIO_SYSCONFIG); > + __raw_writel(gpio_context[i].irqenable1, > + bank->base + OMAP24XX_GPIO_IRQENABLE1); > + __raw_writel(gpio_context[i].irqenable2, > + bank->base + OMAP24XX_GPIO_IRQENABLE2); > do you want to write to the IRQENABLE register even before configuring the rest of the registers (such as data direction etc? usually my understanding was: configure the device, enable the irq.. Regards, Nishanth Menon