Re: [PATCH 01/28] OMAP3: PM: GPMC context save/restore

Nishanth Menon
2009-10-05T17:58:43Z

Kevin Hilman had written, on 10/05/2009 12:29 PM, the following:
> Nishanth Menon <menon.nishanth@gmail.com> writes:

>>> + gpmc_context.cs_context[i].is_valid =
>>> + (gpmc_cs_read_reg(i, GPMC_CS_CONFIG7))
>>> + & GPMC_CONFIG7_CSVALID;
>>> + if (gpmc_context.cs_context[i].is_valid) {
>>> + gpmc_context.cs_context[i].config1 =
>>> + gpmc_cs_read_reg(i, GPMC_CS_CONFIG1);
>>> + gpmc_context.cs_context[i].config2 =
>>> + gpmc_cs_read_reg(i, GPMC_CS_CONFIG2);
>>> + gpmc_context.cs_context[i].config3 =
>>> + gpmc_cs_read_reg(i, GPMC_CS_CONFIG3);
>>> + gpmc_context.cs_context[i].config4 =
>>> + gpmc_cs_read_reg(i, GPMC_CS_CONFIG4);
>>> + gpmc_context.cs_context[i].config5 =
>>> + gpmc_cs_read_reg(i, GPMC_CS_CONFIG5);
>>> + gpmc_context.cs_context[i].config6 =
>>> + gpmc_cs_read_reg(i, GPMC_CS_CONFIG6);
>>> + gpmc_context.cs_context[i].config7 =
>>> + gpmc_cs_read_reg(i, GPMC_CS_CONFIG7);
>>> + }
>>>
>> here is a theoretical bug:
>> 1: GPMC, 1, 2, 3 4 5 configured 6 7 not configured.
>> 2. Save and restore 1: save and restore variables which are static will
>> contain 1-5 and not 6&7
>> 3. next I disable 2,3
>> 3. save will save 1,4,5 BUT my variable will contain 1,2,3,4,5 ->
>> restore will rename 2,3 (which I did not intend)..
>
> Not sure I follow the problem here. What do you mean by "rename".
> The saved context will have values for 2 and 3, but the is_valid
> flag will not be set, so they shouldn't be used.
My bad.. s/rename/enable/ for 2,3 ->definitely not something I would
like to see.

>
> Rajendra was the original author of these, so maybe I'm not fully
> understanding here, but disabling a GPMC looks to me like it
> will disable both the save and restore.

Yes, anyone else has an opinion, please pop them here.

--
Regards,
Nishanth Menon