From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH] OMAP3: PM: Fix VDD2 OPP1 issue Date: Thu, 8 Oct 2009 09:20:35 -0500 Message-ID: <4ACDF533.30205@ti.com> References: <5A47E75E594F054BAF48C5E4FC4B92AB030A3D062B@dbde02.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:55941 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754389AbZJHOVO (ORCPT ); Thu, 8 Oct 2009 10:21:14 -0400 In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB030A3D062B@dbde02.ent.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Reddy, Teerth" Cc: "linux-omap@vger.kernel.org" , Kevin Hilman Reddy, Teerth had written, on 10/08/2009 04:21 AM, the following: > From 144669d941a432875db37ae9431847f6753e566e Mon Sep 17 00:00:00 2001 > From: Teerth Reddy > Date: Wed, 9 Sep 2009 11:01:04 +0530 > Subject: [PATCH] ARM: OMAP3: PM: Fix VDD2 OPP1 issue > > This patch fixes the VDD2 OPP1 issue. The patch has change > which does not allow VDD2 OPP setting to 1.VDD2 should not be put > at OPP1 as this is not a supported OPP for VDD2 > > Signed-off-by: Teerth Reddy > --- > arch/arm/mach-omap2/pm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c > index fec7d00..d0e03c4 100644 > --- a/arch/arm/mach-omap2/pm.c > +++ b/arch/arm/mach-omap2/pm.c > @@ -195,7 +195,7 @@ static ssize_t vdd_opp_store(struct kobject *kobj, struct kobj_attribute *attr, > } > resource_set_opp_level(VDD1_OPP, value, flags); > } else if (attr == &vdd2_opp_attr) { > - if (value < 1 || value > 3) { > + if (value < 2 || value > 3) { > printk(KERN_ERR "vdd_opp_store: Invalid value\n"); > return -EINVAL; > } this is not scalable. we should be able to disable OPPs for each OPP from the OPP array. with different silicons, we could have the same OPP enabled/disabled. NAK -> need to handle based on mpu_opps[vale].rate ==0 -- Regards, Nishanth Menon