[PATCH RESEND] I2C: OMAP: Add missing wakeup events

[PATCH RESEND] I2C: OMAP: Add missing wakeup events

[Aaro Koskinen]

From: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>

Include wake up events for receiver overflow and transmitter
underflow in OMAP_I2C_WE_REG configuration. Also fix a small
typo.

Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
---
 drivers/i2c/busses/i2c-omap.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 827da08..34ea9ed 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -92,8 +92,10 @@
 #define OMAP_I2C_STAT_AL	(1 << 0)	/* Arbitration lost int ena */
 
 /* I2C WE wakeup enable register */
-#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakup */
+#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakeup */
 #define OMAP_I2C_WE_RDR_WE	(1 << 13)	/* RX drain wakeup */
+#define OMAP_I2C_WE_ROVR_WE	(1 << 11)	/* RX overflow wakeup */
+#define OMAP_I2C_WE_XUDF_WE	(1 << 10)	/* TX underflow wakeup */
 #define OMAP_I2C_WE_AAS_WE	(1 << 9)	/* Address as slave wakeup*/
 #define OMAP_I2C_WE_BF_WE	(1 << 8)	/* Bus free wakeup */
 #define OMAP_I2C_WE_STC_WE	(1 << 6)	/* Start condition wakeup */
@@ -104,6 +106,7 @@
 #define OMAP_I2C_WE_AL_WE	(1 << 0)	/* Arbitration lost wakeup */
 
 #define OMAP_I2C_WE_ALL		(OMAP_I2C_WE_XDR_WE | OMAP_I2C_WE_RDR_WE | \
+				OMAP_I2C_WE_ROVR_WE | OMAP_I2C_WE_XUDF_WE | \
 				OMAP_I2C_WE_AAS_WE | OMAP_I2C_WE_BF_WE | \
 				OMAP_I2C_WE_STC_WE | OMAP_I2C_WE_GC_WE | \
 				OMAP_I2C_WE_DRDY_WE | OMAP_I2C_WE_ARDY_WE | \
-- 
1.6.0.4

RE: [PATCH RESEND] I2C: OMAP: Add missing wakeup events

[Sonasath, Moiz]

Hello Aaro!

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Aaro Koskinen
> Sent: Monday, October 12, 2009 5:21 AM
> To: ben-linux@fluff.org; linux-i2c@vger.kernel.org
> Cc: linux-omap@vger.kernel.org; j-pakaravoor@ti.com
> Subject: [PATCH RESEND] I2C: OMAP: Add missing wakeup events
> 
> From: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
> 
> Include wake up events for receiver overflow and transmitter
> underflow in OMAP_I2C_WE_REG configuration. Also fix a small
> typo.
> 
> Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> ---
>  drivers/i2c/busses/i2c-omap.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 827da08..34ea9ed 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -92,8 +92,10 @@
>  #define OMAP_I2C_STAT_AL	(1 << 0)	/* Arbitration lost int ena */
> 
>  /* I2C WE wakeup enable register */
> -#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakup */
> +#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakeup */
>  #define OMAP_I2C_WE_RDR_WE	(1 << 13)	/* RX drain wakeup */
> +#define OMAP_I2C_WE_ROVR_WE	(1 << 11)	/* RX overflow wakeup */
> +#define OMAP_I2C_WE_XUDF_WE	(1 << 10)	/* TX underflow wakeup */

These bits are not documented in OMAP3430, they are reserved. How can we use them?

>  #define OMAP_I2C_WE_AAS_WE	(1 << 9)	/* Address as slave wakeup*/
>  #define OMAP_I2C_WE_BF_WE	(1 << 8)	/* Bus free wakeup */
>  #define OMAP_I2C_WE_STC_WE	(1 << 6)	/* Start condition wakeup */
> @@ -104,6 +106,7 @@
>  #define OMAP_I2C_WE_AL_WE	(1 << 0)	/* Arbitration lost wakeup */
> 
>  #define OMAP_I2C_WE_ALL		(OMAP_I2C_WE_XDR_WE |
> OMAP_I2C_WE_RDR_WE | \
> +				OMAP_I2C_WE_ROVR_WE | OMAP_I2C_WE_XUDF_WE | \
>  				OMAP_I2C_WE_AAS_WE | OMAP_I2C_WE_BF_WE | \
>  				OMAP_I2C_WE_STC_WE | OMAP_I2C_WE_GC_WE | \
>  				OMAP_I2C_WE_DRDY_WE | OMAP_I2C_WE_ARDY_WE | \
> --
> 1.6.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Regards
Moiz Sonasath

RE: [PATCH RESEND] I2C: OMAP: Add missing wakeup events

[Sonasath, Moiz]

Hello Aaro!

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Aaro Koskinen
> Sent: Monday, October 12, 2009 5:21 AM
> To: ben-linux@fluff.org; linux-i2c@vger.kernel.org
> Cc: linux-omap@vger.kernel.org; j-pakaravoor@ti.com
> Subject: [PATCH RESEND] I2C: OMAP: Add missing wakeup events
> 
> From: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
> 
> Include wake up events for receiver overflow and transmitter
> underflow in OMAP_I2C_WE_REG configuration. Also fix a small
> typo.
> 
> Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> ---
>  drivers/i2c/busses/i2c-omap.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 827da08..34ea9ed 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -92,8 +92,10 @@
>  #define OMAP_I2C_STAT_AL	(1 << 0)	/* Arbitration lost int ena */
> 
>  /* I2C WE wakeup enable register */
> -#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakup */
> +#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakeup */
>  #define OMAP_I2C_WE_RDR_WE	(1 << 13)	/* RX drain wakeup */
> +#define OMAP_I2C_WE_ROVR_WE	(1 << 11)	/* RX overflow wakeup */
> +#define OMAP_I2C_WE_XUDF_WE	(1 << 10)	/* TX underflow wakeup */

These bits are not documented in OMAP3430, they are reserved. How can they be used?

>  #define OMAP_I2C_WE_AAS_WE	(1 << 9)	/* Address as slave wakeup*/
>  #define OMAP_I2C_WE_BF_WE	(1 << 8)	/* Bus free wakeup */
>  #define OMAP_I2C_WE_STC_WE	(1 << 6)	/* Start condition wakeup */
> @@ -104,6 +106,7 @@
>  #define OMAP_I2C_WE_AL_WE	(1 << 0)	/* Arbitration lost wakeup */
> 
>  #define OMAP_I2C_WE_ALL		(OMAP_I2C_WE_XDR_WE |
> OMAP_I2C_WE_RDR_WE | \
> +				OMAP_I2C_WE_ROVR_WE | OMAP_I2C_WE_XUDF_WE | \
>  				OMAP_I2C_WE_AAS_WE | OMAP_I2C_WE_BF_WE | \
>  				OMAP_I2C_WE_STC_WE | OMAP_I2C_WE_GC_WE | \
>  				OMAP_I2C_WE_DRDY_WE | OMAP_I2C_WE_ARDY_WE | \
> --
> 1.6.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Regards
Moiz Sonasath

Re: [PATCH RESEND] I2C: OMAP: Add missing wakeup events

[Aaro Koskinen]

Hello,

Sonasath, Moiz wrote:
>> From: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor-l0cyMroinI0@public.gmane.org>
>>
>> Include wake up events for receiver overflow and transmitter
>> underflow in OMAP_I2C_WE_REG configuration. Also fix a small
>> typo.
>>
>> Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor-l0cyMroinI0@public.gmane.org>
>> Signed-off-by: Aaro Koskinen <aaro.koskinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
>> ---
>>  drivers/i2c/busses/i2c-omap.c |    5 ++++-
>>  1 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
>> index 827da08..34ea9ed 100644
>> --- a/drivers/i2c/busses/i2c-omap.c
>> +++ b/drivers/i2c/busses/i2c-omap.c
>> @@ -92,8 +92,10 @@
>>  #define OMAP_I2C_STAT_AL	(1 << 0)	/* Arbitration lost int ena */
>>
>>  /* I2C WE wakeup enable register */
>> -#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakup */
>> +#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakeup */
>>  #define OMAP_I2C_WE_RDR_WE	(1 << 13)	/* RX drain wakeup */
>> +#define OMAP_I2C_WE_ROVR_WE	(1 << 11)	/* RX overflow wakeup */
>> +#define OMAP_I2C_WE_XUDF_WE	(1 << 10)	/* TX underflow wakeup */
> 
> These bits are not documented in OMAP3430, they are reserved. How can they be used?

Hmm, that's a valid point. I will have to check if I can find more info on the background of this patch.

A.

RE: [PATCH RESEND] I2C: OMAP: Add missing wakeup events

[Sonasath, Moiz]

Hello Aaro!

> -----Original Message-----
> From: Aaro Koskinen [mailto:aaro.koskinen@nokia.com]
> Sent: Tuesday, October 13, 2009 4:52 AM
> To: Sonasath, Moiz
> Cc: ben-linux@fluff.org; linux-i2c@vger.kernel.org; linux-
> omap@vger.kernel.org
> Subject: Re: [PATCH RESEND] I2C: OMAP: Add missing wakeup events
> 
> Hello,
> 
> Sonasath, Moiz wrote:
> >> From: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
> >>
> >> Include wake up events for receiver overflow and transmitter
> >> underflow in OMAP_I2C_WE_REG configuration. Also fix a small
> >> typo.
> >>
> >> Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
> >> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> >> ---
> >>  drivers/i2c/busses/i2c-omap.c |    5 ++++-
> >>  1 files changed, 4 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-
> omap.c
> >> index 827da08..34ea9ed 100644
> >> --- a/drivers/i2c/busses/i2c-omap.c
> >> +++ b/drivers/i2c/busses/i2c-omap.c
> >> @@ -92,8 +92,10 @@
> >>  #define OMAP_I2C_STAT_AL	(1 << 0)	/* Arbitration lost int ena */
> >>
> >>  /* I2C WE wakeup enable register */
> >> -#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakup */
> >> +#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakeup */
> >>  #define OMAP_I2C_WE_RDR_WE	(1 << 13)	/* RX drain wakeup */
> >> +#define OMAP_I2C_WE_ROVR_WE	(1 << 11)	/* RX overflow wakeup */
> >> +#define OMAP_I2C_WE_XUDF_WE	(1 << 10)	/* TX underflow wakeup */
> >
> > These bits are not documented in OMAP3430, they are reserved. How can
> they be used?
> 
> Hmm, that's a valid point. I will have to check if I can find more info on
> the background of this patch.

AFAIK, these bits have been introduced in OMAP3630 as it has a new IP block for I2C. But these bits are reserved bits for OMAP3430.

> 
> A.

RE: [PATCH RESEND] I2C: OMAP: Add missing wakeup events

[Woodruff, Richard]

> > >>  /* I2C WE wakeup enable register */
> > >> -#define OMAP_I2C_WE_XDR_WE      (1 << 14)       /* TX drain wakup */
> > >> +#define OMAP_I2C_WE_XDR_WE      (1 << 14)       /* TX drain wakeup */
> > >>  #define OMAP_I2C_WE_RDR_WE      (1 << 13)       /* RX drain wakeup */
> > >> +#define OMAP_I2C_WE_ROVR_WE     (1 << 11)       /* RX overflow wakeup */
> > >> +#define OMAP_I2C_WE_XUDF_WE     (1 << 10)       /* TX underflow wakeup */
> > >
> > > These bits are not documented in OMAP3430, they are reserved. How can
> > they be used?
> >
> > Hmm, that's a valid point. I will have to check if I can find more info on
> > the background of this patch.
>
> AFAIK, these bits have been introduced in OMAP3630 as it has a new IP block
> for I2C. But these bits are reserved bits for OMAP3430.

Couple notes:
        - IP block is updated but it is not new.  These should just be some reserved bits converted.  New bits expand wakeup capability and enhance FIFO operation with DMA.

        - Driver for a while supported OMAP1/2420 style I2C and OMAP2430/3/4 style I2C.  Definitions between broad class drivers are different.  The interrupt handler is easiest to see this.  This is not so relevant to above bits but is good to keep in mind.

Regards,
Richard W.