public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
Cc: "Pandita, Vikram" <vikram.pandita@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] omap: Fix 35xx detection (Re: [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero)
Date: Tue, 13 Oct 2009 13:31:58 -0500	[thread overview]
Message-ID: <4AD4C79E.4050601@ti.com> (raw)
In-Reply-To: <20091013173233.GU12700@atomide.com>

Tony Lindgren had written, on 10/13/2009 12:32 PM, the following:
> * Tony Lindgren <tony@atomide.com> [091013 10:18]:
>> * Vikram Pandita <vikram.pandita@ti.com> [091012 14:31]:
>>> make default cpu_is_omap3630() return zero
>>>
>>> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
>>> ---
>>>  arch/arm/plat-omap/include/mach/cpu.h |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/plat-omap/include/mach/cpu.h b/arch/arm/plat-omap/include/mach/cpu.h
>>> index da9e8f8..940946e 100644
>>> --- a/arch/arm/plat-omap/include/mach/cpu.h
>>> +++ b/arch/arm/plat-omap/include/mach/cpu.h
>>> @@ -322,6 +322,7 @@ IS_OMAP_TYPE(3430, 0x3430)
>>>  #define cpu_is_omap2423()		0
>>>  #define cpu_is_omap2430()		0
>>>  #define cpu_is_omap3430()		0
>>> +#define cpu_is_omap3630()		0
>>>  
>>>  /*
>>>   * Whether we have MULTI_OMAP1 or not, we still need to distinguish
>>> @@ -386,6 +387,7 @@ IS_OMAP_TYPE(3430, 0x3430)
>>>  						(omap3_has_sgx()) &	\
>>>  						(!omap3_has_iva()))
>>>  # define cpu_is_omap3530		(cpu_is_omap3430())
>>> +# undef cpu_is_omap3630()
>>>  # define cpu_is_omap3630()		is_omap363x()
wondering what the standard is:
  # define cpu_is_omap3430()		is_omap3430()
so is it
  #define cpu_is_omapXXXX() 		blah blah
or
  #define cpu_is_omapXXXX		blah blah
would have though it is  cpu_is_omapXXXX()

Regards,
Nishanth Menon

  reply	other threads:[~2009-10-13 18:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 20:51 [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero Vikram Pandita
2009-10-12 21:05 ` Menon, Nishanth
2009-10-12 21:07   ` Pandita, Vikram
2009-10-12 21:09     ` Menon, Nishanth
2009-10-13 10:03     ` Shilimkar, Santosh
2009-10-13 10:14       ` Nishanth Menon
2009-10-13 17:15         ` Tony Lindgren
2009-10-13 17:43           ` [PATCH] omap: Fix cpu_is_omap35xx default defines (Re: [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero) Tony Lindgren
2009-10-13 17:18 ` [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero Tony Lindgren
2009-10-13 17:32   ` [PATCH] omap: Fix 35xx detection (Re: [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero) Tony Lindgren
2009-10-13 18:31     ` Nishanth Menon [this message]
2009-10-13 19:09     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD4C79E.4050601@ti.com \
    --to=nm@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=vikram.pandita@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox