Re: MMC_CAP_SDIO_IRQ for omap 3430

[Dirk Behme <dirk.behme@googlemail.com>]

John Rigby wrote:
> In enable_sdio_irq
> if enable
>   set ctpl
> else
>   clear ctpl

It would really help avoiding mails like this if you just would send 
your changes. We know that they are for an old kernel and just a dirty 
hack.

Dirk

> On Tue, Oct 20, 2009 at 4:47 PM, Madhusudhan <madhu.cr@ti.com> wrote:
>>
>>> -----Original Message-----
>>> From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-
>>> owner@vger.kernel.org] On Behalf Of Dirk Behme
>>> Sent: Monday, October 19, 2009 1:17 PM
>>> To: linux-omap@vger.kernel.org
>>> Cc: Madhusudhan; 'John Rigby'; 'Woodruff, Richard'; linux-
>>> mmc@vger.kernel.org; 'Steve Sakoman'
>>> Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430
>>>
>>> Madhusudhan wrote:
>>>> Hi John,
>>>>
>>>> So does the SDIO card interrupt mode work fine now?
>>> (wrong attachment in previous mail :( sorry)
>>>
>>> If somebody likes to test, my updated patch v2 in attachment. Compile
>>> tested only, testing and comments are welcome.
>>>
>> Can you inline the v2 patch please? It helps review. I wonder in the version
>> that John tested was the CTPL bit set in "set_ios" or "enable_sdio_irq"?
>>
>> Regards,
>> Madhu
>>
>>> Cheers
>>>
>>> Dirk
>>>
>>>>   _____
>>>>
>>>> From: John Rigby [mailto:jcrigby@gmail.com]
>>>> Sent: Sunday, October 18, 2009 7:24 PM
>>>> To: Woodruff, Richard
>>>> Cc: Dirk Behme; Chikkature Rajashekar, Madhusudhan;
>>>> linux-mmc@vger.kernel.org; linux-omap@vger.kernel.org; Steve Sakoman
>>>> Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430
>>>>
>>>>
>>>>
>>>> Ok I was going to ask where you found that but I just rechecked the TRM
>>> and
>>>> there it is in plain site:
>>>>
>>>>
>>>>
>>>> When this bit is set to 1, the host controller automatically disables
>>> all
>>>> the input buffers except the buffer of mmci_dat[1] outside of a
>>> transaction
>>>> in order to detect asynchronous card interrupt on mmci_dat[1] line and
>>>> minimize the leakage current of the buffers.
>>>>
>>>>
>>>> In my defence, I did search the TRM for every occurance of dat1 but not
>>>> dat[1].  Oh well live and learn and forget and repeat.
>>>>
>>>> John
>>>>
>>>> On Sun, Oct 18, 2009 at 6:17 PM, John Rigby <jcrigby@gmail.com> wrote:
>>>>> Richard,
>>>>>
>>>>> MMCHS_CON.CPTL = 1  < Don't disable input buffer on DAT1 after
>>>>> completion to allow seeing SDIO interrupt>
>>>>>
>>>>> Sounds exactly like what we need.
>>>>>
>>>>> Thanks
>>>>> John
>>>>>
>>>>> On Sun, Oct 18, 2009 at 5:12 PM, Woodruff, Richard <r-woodruff2@ti.com>
>>>> wrote:
>>>>>>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>>>>>>> owner@vger.kernel.org] On Behalf Of Dirk Behme
>>>>>>> Sent: Sunday, October 18, 2009 11:45 AM
>>>>>>>> It would be funny if the TRM was wrong and the CIRQ bit is really
>>>>>>>> cleared by writing 1 to it.  I'll try that.
>>>>>> A while back I hunted down a few of the bits for this.  Maybe this
>>> will
>>>> help some.
>>>>>> SYSCONFIG.ENAWAKEUP = 1 < allow ocp wrapper to generate an interrupt
>>> to
>>>> prcm>
>>>>>> MMCHS_HCTL.IWE = 1 < route wake up to module ocp wrapper>
>>>>>> MMCHS_CON.CPTL = 1  < Don't disable input buffer on DAT1 after
>>> completion
>>>> to allow seeing SDIO interrupt>
>>>>>> MMCHS_HCTL.IWE
>>>>>> MMCHS_ISE.CIRQ_ENABLE <bit to write to enable interrupt at pin>
>>>>>> MMCHS_STAT<bit to write for clear of SDIO interrupt>
>>>>>> CCCCR - IRQ_ENABLE (think host stack will do this)
>>>>>>
>>>>>> Regards,
>>>>>> Richard W.
>>>>>>
>>>>
>>
>>
>