From: Mike Turquette <mturquette@ti.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Mike Turquette <mturquette@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Sripathy, Vishwanath" <vishwanath.bs@ti.com>
Subject: Re: [PATCH] OMAP3: decrease cpufreq transition latency
Date: Thu, 29 Oct 2009 16:47:29 -0500 [thread overview]
Message-ID: <4AEA0D71.5020906@ti.com> (raw)
In-Reply-To: <87k4ydzyvg.fsf@deeprootsystems.com>
Kevin Hilman wrote:
> Mike Turquette <mturquette@gmail.com> writes:
>
>> Adjust OMAP3 frequency transition latency from 10,000,000uS to a more
>> reasonable 300,000uS. This causes ondemand and conservative governors to
>> sample CPU load more often resulting in more responsive behavior.
>>
>> Tested on Android 2.6.29; using this value and conservative governor, CORE
>> power consumption on Zoom2 was comparable to the old and unresponsive
>> 10,000,000uS value while UI responsiveness was greatly improved.
>>
>> This patch applies against Tony's omap-fixes branch.
>>
>> Signed-off-by: Mike Turquette <mturquette@ti.com>
>> ---
>> arch/arm/plat-omap/cpu-omap.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/cpu-omap.c b/arch/arm/plat-omap/cpu-omap.c
>> index 1868c0d..341235c 100644
>> --- a/arch/arm/plat-omap/cpu-omap.c
>> +++ b/arch/arm/plat-omap/cpu-omap.c
>> @@ -127,7 +127,7 @@ static int __init omap_cpu_init(struct cpufreq_policy *policy)
>> }
>>
>> /* FIXME: what's the actual transition time? */
>
> Can probably drop this 'FIXME' comment now.
I chose not to drop the FIXME since the worst-case transition time is
still unknown. At some point I'd like to revisit this number with
something better supported by data from the hardware guys. This number
was deemed "safe", but may not be optimal.
Mike
>> - policy->cpuinfo.transition_latency = 10 * 1000 * 1000;
>> + policy->cpuinfo.transition_latency = 300 * 1000;
>
> otherwise,
>
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
>
> Tony, can this still be queued for .32-rc?
>
> Kevin
>
next prev parent reply other threads:[~2009-10-29 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 21:02 [PATCH] OMAP3: decrease cpufreq transition latency Mike Turquette
2009-10-29 21:14 ` Kevin Hilman
2009-10-29 21:47 ` Mike Turquette [this message]
2009-10-29 21:38 ` Kevin Hilman
2009-11-03 17:08 ` Tony Lindgren
2009-11-10 0:45 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEA0D71.5020906@ti.com \
--to=mturquette@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@gmail.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox