From: Chris Hudson <chudson@kionix.com>
To: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Driver Merge Questions
Date: Tue, 03 Nov 2009 09:40:17 -0500 [thread overview]
Message-ID: <4AF040D1.7020109@kionix.com> (raw)
Hello all,
I've never submitted any software to Linux before, but I've been working
on some new accelerometer drivers that should be ready for review soon
(pending company approval). I've read lots of documentation on patch
and driver submissions, but I still have some questions that I was
hoping someone could help me find the answers to.
1- My drivers use i2c for hardware communications, miscdevice for
IOCTLs, and input_dev for data and interrupt status outputs. Most of
the other accelerometer drivers that I've looked at use similar designs
and are located in drivers/hwmon, but I just wanted to confirm that this
is the correct location currently.
2- I have done all of my hardware testing with OMAP development
platforms, so I thought it would be best to send my patch submissions to
this list for review. The hardware monitoring tree is listed in
MAINTAINERS as an orphan, but I was planning on including
lm-sensors@lm-sensors.org as well. If either of these assumptions is
incorrect, please let me know.
3- Should my patch set consist of source, header, kconfig, and makefile
patches, or should I include my custom changes to mux.c, mux.h, and
board-zoom2.c as well? The former are necessary for adding driver
support, but the latter are specific for my hardware testing platform
(which others may want to duplicate for testing purposes). I noticed
that recent versions of board-zoom2.c are nice and clean, so it's
probably not a good idea to wedge infrequently-used code in there with a
bunch of #ifdefs. I just want to get an idea of what is generally
included with a new driver.
Any help or advice would be greatly appreciated.
Thank you,
Chris Hudson
Kionix, Inc.
next reply other threads:[~2009-11-03 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 14:40 Chris Hudson [this message]
2009-11-03 16:58 ` Driver Merge Questions Tony Lindgren
2009-11-09 9:26 ` Amit Kucheria
2009-11-09 12:07 ` Amit Kucheria
2009-11-09 14:54 ` Chris Hudson
2009-11-09 17:09 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF040D1.7020109@kionix.com \
--to=chudson@kionix.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox