Re: [PATCH] Disable headset jack detection for SDP3430

[Nishanth Menon <nm@ti.com>]

Romero, Felipe had written, on 11/10/2009 11:54 AM, the following:
> From: Felipe Romero <felipe.romero@ti.com>
> 
> This patch Disable headset jack detection for SDP3430 boards,
> to avoid CPU kernel utilization.

please read Documentation/SubmittingPatches
12) Sign your work

> ---
>  sound/soc/omap/sdp3430.c |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/soc/omap/sdp3430.c b/sound/soc/omap/sdp3430.c
> index b719e5d..3ef489e 100644
> --- a/sound/soc/omap/sdp3430.c
> +++ b/sound/soc/omap/sdp3430.c
> @@ -196,8 +196,8 @@ static int sdp3430_twl4030_init(struct snd_soc_codec *codec)
>  	/* SDP3430 connected pins */
>  	snd_soc_dapm_enable_pin(codec, "Ext Mic");
>  	snd_soc_dapm_enable_pin(codec, "Ext Spk");
> -	snd_soc_dapm_disable_pin(codec, "Headset Mic");
> -	snd_soc_dapm_disable_pin(codec, "Headset Stereophone");
> +	snd_soc_dapm_enable_pin(codec, "Headset Mic");
> +	snd_soc_dapm_enable_pin(codec, "Headset Stereophone");
>  
>  	/* TWL4030 not connected pins */
>  	snd_soc_dapm_nc_pin(codec, "AUXL");
> @@ -217,7 +217,7 @@ static int sdp3430_twl4030_init(struct snd_soc_codec *codec)
>  	ret = snd_soc_dapm_sync(codec);
>  	if (ret)
>  		return ret;
> -
> +#if 0
NAK to #if 0s. if you dont need that code, please remove it
>  	/* Headset jack detection */
>  	ret = snd_soc_jack_new(&snd_soc_sdp3430, "Headset Jack",
>  				SND_JACK_HEADSET, &hs_jack);
> @@ -231,7 +231,7 @@ static int sdp3430_twl4030_init(struct snd_soc_codec *codec)
>  
>  	ret = snd_soc_jack_add_gpios(&hs_jack, ARRAY_SIZE(hs_jack_gpios),
>  				hs_jack_gpios);
> -
> +#endif
>  	return ret;
>  }
>  
> @@ -328,9 +328,10 @@ module_init(sdp3430_soc_init);
>  
>  static void __exit sdp3430_soc_exit(void)
>  {
> +#if 0
NAK to #if 0s. if you dont need that code, please remove it
>  	snd_soc_jack_free_gpios(&hs_jack, ARRAY_SIZE(hs_jack_gpios),
>  				hs_jack_gpios);
> -
> +#endif
>  	platform_device_unregister(sdp3430_snd_device);
>  }
>  module_exit(sdp3430_soc_exit);


-- 
Regards,
Nishanth Menon