Re: [PATCH 2/8] musb: Get power (mA) from board data

[Sergei Shtylyov <sshtylyov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>]

Hello.

Ajay Kumar Gupta wrote:

> Different board may have different power sourcing capability and
> now with 'struct musb_hdrc_board_data' in place; pass this data
> from board files and also modify musb_core.c to get 'power' data
> from 'plat->board_data'.

    This should be part of the patch 1/8 to keep the code compiling.

> Signed-off-by: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>

> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 3a61ddb..818ccda 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -2033,7 +2033,9 @@ bad_config:
>  		if (is_otg_enabled(musb))
>  			hcd->self.otg_port = 1;
>  		musb->xceiv->host = &hcd->self;
> -		hcd->power_budget = 2 * (plat->power ? : 250);
> +		if (plat->board_data)
> +			hcd->power_budget =
> +				2 * (plat->board_data->power ? : 250);

    Shouldn't it be:

+
+		hcd->power_budget = 2 * (plat->board_data &&
+				         plat->board_data->power ?
+					 plat->board_data->power : 250);

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html