Re: [PATCH 4/8] musb: Update setup_usb() call for all Davinci boards

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Ajay Kumar Gupta wrote:

> setup_usb() has been modified to pass board specific data so updating
> this function call from all Davinci based boards.

> Added "struct device;" to fix below compilation warning for Davinci boards.
> "musb.h: struct device, defined within parameter list"

> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>

[...]

> diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c
> index 06f5593..1b164dc 100644
> --- a/arch/arm/mach-davinci/usb.c
> +++ b/arch/arm/mach-davinci/usb.c
> @@ -85,10 +85,10 @@ static struct platform_device usb_dev = {
>  	.num_resources  = ARRAY_SIZE(usb_resources),
>  };
>  
> -void __init setup_usb(unsigned mA, unsigned potpgt_msec)
> +void __init setup_usb(struct musb_hdrc_board_data *board_data)
>  {
> -	usb_data.power = mA / 2;
> -	usb_data.potpgt = potpgt_msec / 2;

    Hm, again, you can't separate this patch from patch 1/8 to keep the code 
compiling between the patches.  It looks like you have no choice but lump 
most of your patches together (and get rid of some others :-). Either that 
or better separate your change to the struct musb_hdrc_platfrpom_data and 
your change to setup_usb() prototype.

WBR, Sergei