linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
	"Aguirre, Sergio" <saaguirre@ti.com>,
	"Pandita, Vikram" <vikram.pandita@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: FEATURES - is it good enough
Date: Fri, 20 Nov 2009 13:24:13 -0600	[thread overview]
Message-ID: <4B06ECDD.2030100@ti.com> (raw)
In-Reply-To: <87eint3uys.fsf@deeprootsystems.com>

Kevin Hilman had written, on 11/20/2009 12:35 PM, the following:
> "Shilimkar, Santosh" <santosh.shilimkar@ti.com> writes:
> 
> [...]
> 
>>>> Probably not something ot be attached in this patch, but...
>>>>
>>>> I'm a bit curious about something:
>>>>
>>>> Why touching omap3_features in OMAP4?
>>>>
>>>> Isn't there a omap4_features?
>>>>
>>>> Or even better, an omap_features?
>> This "is_feature" suppose to take care of Errata's also, is it?
> 
> "It's not a bug it's a feature." :)
Bug. Santosh pointed out internally to h/w discussion which clearly 
shows this as a h/w limitation. (thanks santosh)

> 
>> This is errata more than a feature..... We better differentiate in
>> this regard
> 
> I agree, I have a hard time calling this empty fifo read fault a
> "feature."  We need a similar thing for errata.
Agreed. This is a classic example why we need a common errata handling 
mechanism scalable across silicon variants on an IP basis. two problems 
in front of us:
a) what do we want to do with 8250 workaround needed for omap3630 and 
omap4? can we go ahead with features marking it clearly as a "misuse of 
features for the time being"
b) a common silicon errata handling mechanism: Does anyone have 
proposals for this? I can see it help in numerous places in our code 
today and will help readability of the code instead of getting the risk 
of "feature not a bug" misread.. ;)..

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2009-11-20 19:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20 16:02 [PATCH v3 0/2] omap: serial: handle abort on empty rx fifo read Vikram Pandita
2009-11-20 16:02 ` [PATCH v3 1/2] omap: introduce uart_no_empty_fifo_read feature Vikram Pandita
2009-11-20 16:02   ` [PATCH v3 2/2] omap: serial: fix non-empty uart fifo read abort Vikram Pandita
2009-11-20 16:09   ` [PATCH v3 1/2] omap: introduce uart_no_empty_fifo_read feature Nishanth Menon
2009-11-20 16:14     ` Aguirre, Sergio
2009-11-20 16:16       ` FEATURES - is it good enough (was Re: [PATCH v3 1/2] omap: introduce uart_no_empty_fifo_read feature) Nishanth Menon
2009-11-20 17:06         ` Shilimkar, Santosh
2009-11-20 18:35           ` FEATURES - is it good enough Kevin Hilman
2009-11-20 19:24             ` Nishanth Menon [this message]
2009-11-20 19:41               ` Premi, Sanjeev
2009-11-20 19:43               ` Aguirre, Sergio
2009-11-20 20:07                 ` Ramirez Luna, Omar
2009-11-20 20:13                   ` Aguirre, Sergio
2009-11-20 20:09                 ` Nishanth Menon
2009-12-01 15:42                   ` Alexander Shishkin
2009-12-02  6:06                     ` Menon, Nishanth
2009-12-02  9:05                       ` Alexander Shishkin
2009-12-01 13:20 ` [PATCH v3 0/2] omap: serial: handle abort on empty rx fifo read Gadiyar, Anand
2009-12-01 16:05   ` Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B06ECDD.2030100@ti.com \
    --to=nm@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=saaguirre@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=vikram.pandita@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).