From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/6] OMAP4: Re-arrange the low level debug code
Date: Thu, 10 Dec 2009 15:56:10 +0300 [thread overview]
Message-ID: <4B20EFEA.8000205@ru.mvista.com> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02BC0A8766@dbde02.ent.ti.com>
Hello.
Shilimkar, Santosh wrote:
>> -----Original Message-----
>> From: Sergei Shtylyov [mailto:sshtylyov@ru.mvista.com]
>> Sent: Thursday, December 10, 2009 4:06 PM
>> To: Shilimkar, Santosh
>> Cc: tony@atomide.com; linux-omap@vger.kernel.org; linux@arm.linux.org.uk; linux-arm-
>> kernel@lists.infradead.org
>> Subject: Re: [PATCH 3/6] OMAP4: Re-arrange the low level debug code
>>
>> Hello.
>>
>> Santosh Shilimkar wrote:
>>
>>
>>> On OMAP4430 the UART3 base address is different than that on OMAP3.
>>> Because of this existing code needs additional #ifdef'ry to accommodate
>>> that code. Hence this patch separates it. Also UART3 base address is
>>> fixed for OMAP4430 in this patch.
>>>
>>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>
>>>
>> [...]
>>
>>> diff --git a/arch/arm/mach-omap2/include/mach/debug-macro.S b/arch/arm/mach-
>>>
>> omap2/include/mach/debug-macro.S
>>
>>> index e9f255d..b2b4b29 100644
>>> --- a/arch/arm/mach-omap2/include/mach/debug-macro.S
>>> +++ b/arch/arm/mach-omap2/include/mach/debug-macro.S
>>> @@ -25,7 +25,7 @@
>>> add \rx, \rx, #0x00004000 @ UART 3
>>> #endif
>>>
>>> -#elif defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4)
>>> +#elif CONFIG_ARCH_OMAP3
>>>
>>>
>> Why you've dropped defined()? This doesn't seem right as it should
>> cause error when CONFIG_ARCH_OMAP3=n...
>>
>
> Before omap4 support was added, it was as above. Now when I decided
> to go back and spilt it I changed it. How the ARCH flag will be
> n ? It will be either 0 or 1
>
This is .config variable -- it's either 1 or *not defined*.
WBR, Sergei
next prev parent reply other threads:[~2009-12-10 12:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 18:29 [PATCH 1/6] OMAP4: Fix cpu detection Santosh Shilimkar
2009-12-09 18:29 ` [PATCH 2/6] OMAP4: Fix SRAM base and size Santosh Shilimkar
2009-12-09 18:29 ` [PATCH 3/6] OMAP4: Re-arrange the low level debug code Santosh Shilimkar
2009-12-09 18:29 ` [PATCH 4/6] OMAP4: AuxCoreBoot registers only accessible in secure mode Santosh Shilimkar
2009-12-09 18:29 ` [PATCH 5/6] OMAP4: Remove the secondary wait loop Santosh Shilimkar
2009-12-09 18:29 ` [PATCH 6/6] OMAP4: Sync up omap4430 defconfig Santosh Shilimkar
2009-12-09 18:45 ` Pandita, Vikram
2009-12-09 18:49 ` Shilimkar, Santosh
2009-12-09 18:52 ` Pandita, Vikram
2009-12-09 18:55 ` Shilimkar, Santosh
2009-12-09 18:58 ` Gadiyar, Anand
2009-12-11 22:21 ` [APPLIED] > >[PATCH " Tony Lindgren
2009-12-11 22:21 ` [APPLIED] [PATCH 5/6] OMAP4: Remove the secondary wait loop Tony Lindgren
2009-12-11 22:20 ` [APPLIED] [PATCH 4/6] OMAP4: AuxCoreBoot registers only accessible in secure Tony Lindgren
2009-12-10 10:35 ` [PATCH 3/6] OMAP4: Re-arrange the low level debug code Sergei Shtylyov
2009-12-10 11:27 ` Shilimkar, Santosh
2009-12-10 12:56 ` Sergei Shtylyov [this message]
2009-12-11 22:18 ` [APPLIED] [PATCH 2/6] OMAP4: Fix SRAM base and size Tony Lindgren
2009-12-09 19:30 ` [PATCH 1/6] OMAP4: Fix cpu detection Nishanth Menon
2009-12-09 19:50 ` Shilimkar, Santosh
2009-12-09 19:53 ` Nishanth Menon
2009-12-09 19:33 ` Cousson, Benoit
2009-12-09 19:37 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B20EFEA.8000205@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox