From: Sid Boyce <sboyce@blueyonder.co.uk>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [GIT PULL] omap build fixes
Date: Thu, 17 Dec 2009 22:16:45 +0000 [thread overview]
Message-ID: <4B2AADCD.4080802@blueyonder.co.uk> (raw)
In-Reply-To: <20091217172600.GY4575@atomide.com>
On 17/12/09 17:26, Tony Lindgren wrote:
> * Sid Boyce <sboyce@blueyonder.co.uk> [091217 03:29]:
>
> <snip>
>
>> uImage built, so EHCI build problem definitely fixed, just one error
>> I've previously encountered when building modules.
>> slipstream:/home/lancelot/ftp/dec09/OMAP/omap-fixes-for-linus # ARCH=arm
>> make -j 4 CROSS_COMPILE=/opt/arm-2009q3/bin/arm-none-eabi- modules
>> scripts/kconfig/conf -s arch/arm/Kconfig
>> CHK include/linux/version.h
>> SYMLINK include/asm -> include/asm-arm
>> make[1]: `include/asm-arm/mach-types.h' is up to date.
>> CHK include/linux/utsrelease.h
>> CALL scripts/checksyscalls.sh
>> <stdin>:1523: warning: #warning syscall recvmmsg not implemented
>> Building modules, stage 2.
>> MODPOST 99 modules
>> ERROR: "omap_ctrl_writel" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined!
>> ERROR: "omap_ctrl_readl" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined!
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>
> Hmm. I'm not seeing this in any of the defconfigs, so I guess this
> happens with ASoC complied as a module.
>
> But instead of exporting omap_ctrl_read/write, we need to get rid of
> omap_ctrl_read/write stuff in the drivers.
>
> It seems that omap_mcbsp_dai_set_clks_src() should be implemented in
> the clock framework instead.
>
> Regards,
>
> Tony
>
>
Confirmed it works when compiled in.
Regards
Sid.
--
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks
prev parent reply other threads:[~2009-12-17 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 22:35 [GIT PULL] omap build fixes Tony Lindgren
2009-12-17 11:29 ` Sid Boyce
2009-12-17 17:26 ` Tony Lindgren
2009-12-17 22:16 ` Sid Boyce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2AADCD.4080802@blueyonder.co.uk \
--to=sboyce@blueyonder.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox