public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: "Menon, Nishanth" <nm@ti.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] OMAP OPP: Add accessor function for getting OPP ID.
Date: Sat, 19 Dec 2009 17:26:46 +0530	[thread overview]
Message-ID: <4B2CBF7E.9020504@ti.com> (raw)
In-Reply-To: <1261177539-15429-2-git-send-email-khilman@deeprootsystems.com>

Kevin Hilman said the following on 12/19/2009 04:35 AM:
> Add new function opp_get_opp_id() for finding the OPP ID of a given
> OPP.  This allows us to further hide OPP layer details.
>
> NOTE: OPP IDs are deprecated, and this function will eventually
>       be removed after all users of OPP IDs are removed.
>
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
>  arch/arm/plat-omap/include/plat/opp.h |    1 +
>  arch/arm/plat-omap/opp.c              |    5 +++++
>  2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/opp.h b/arch/arm/plat-omap/include/plat/opp.h
> index cdadf67..6fe574c 100644
> --- a/arch/arm/plat-omap/include/plat/opp.h
> +++ b/arch/arm/plat-omap/include/plat/opp.h
> @@ -243,6 +243,7 @@ int opp_disable(struct omap_opp *opp);
>  
>  struct omap_opp * __deprecated opp_find_by_opp_id(struct omap_opp *opps,
>  						  u8 opp_id);
> +u8 __deprecated opp_get_opp_id(struct omap_opp *opp);
>   
Sigh.. ok... been trying to avoid this precisely :(
Acked-by: Nishanth Menon <nm@ti.com>
>  
>  void opp_init_cpufreq_table(struct omap_opp *opps,
>  			    struct cpufreq_frequency_table **table);
> diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c
> index e7b6f2a..4f7fa22 100644
> --- a/arch/arm/plat-omap/opp.c
> +++ b/arch/arm/plat-omap/opp.c
> @@ -69,6 +69,11 @@ struct omap_opp * __deprecated opp_find_by_opp_id(struct omap_opp *opps,
>  	return NULL;
>  }
>  
> +u8 __deprecated opp_get_opp_id(struct omap_opp *opp)
> +{
> +	return opp->opp_id;
> +}
> +
>  int opp_get_opp_count(struct omap_opp *oppl)
>  {
>  	u8 n = 0;
>   


  parent reply	other threads:[~2009-12-19 11:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-18 23:05 [PATCH v2 0/4] OPP layer: hide OPP implementation details Kevin Hilman
2009-12-18 23:05 ` [PATCH v2 1/4] OMAP OPP: Add accessor function for getting OPP ID Kevin Hilman
2009-12-18 23:05   ` [PATCH v2 2/4] OMAP SRF: adjust OPP array access Kevin Hilman
2009-12-18 23:05     ` [PATCH v2 3/4] OMAP SR/SRF: use OPP API for OPP ID, remove direct access Kevin Hilman
2009-12-18 23:05       ` [PATCH v2 4/4] OMAP OPP: hide struct omap_opp internals in OPP layer implementation Kevin Hilman
2009-12-19 12:04         ` Menon, Nishanth
2009-12-19 12:03       ` [PATCH v2 3/4] OMAP SR/SRF: use OPP API for OPP ID, remove direct access Menon, Nishanth
2009-12-22 16:16         ` Kevin Hilman
2009-12-19 12:00     ` [PATCH v2 2/4] OMAP SRF: adjust OPP array access Menon, Nishanth
2009-12-19 11:56   ` Menon, Nishanth [this message]
2009-12-21  7:11   ` [PATCH v2 1/4] OMAP OPP: Add accessor function for getting OPP ID Romit Dasgupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2CBF7E.9020504@ti.com \
    --to=nm@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox