From: "Menon, Nishanth" <nm@ti.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] OMAP SRF: adjust OPP array access
Date: Sat, 19 Dec 2009 17:30:42 +0530 [thread overview]
Message-ID: <4B2CC06A.3080503@ti.com> (raw)
In-Reply-To: <1261177539-15429-3-git-send-email-khilman@deeprootsystems.com>
Kevin Hilman said the following on 12/19/2009 04:35 AM:
> With the initial terminators removed from the OPP struct arrarys,
> the direct indexing of the array needs to be adjusted by one.
>
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> arch/arm/mach-omap2/resource34xx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/resource34xx.c b/arch/arm/mach-omap2/resource34xx.c
> index 05e70b7..1fa8bb5 100644
> --- a/arch/arm/mach-omap2/resource34xx.c
> +++ b/arch/arm/mach-omap2/resource34xx.c
> @@ -337,8 +337,8 @@ static int program_opp(int res, struct omap_opp *opp, int target_level,
> #ifdef CONFIG_OMAP_SMARTREFLEX
> unsigned long t_opp, c_opp;
>
> - t_opp = ID_VDD(res) | ID_OPP_NO(opp[target_level].opp_id);
> - c_opp = ID_VDD(res) | ID_OPP_NO(opp[current_level].opp_id);
> + t_opp = ID_VDD(res) | ID_OPP_NO(opp[target_level - 1].opp_id);
> + c_opp = ID_VDD(res) | ID_OPP_NO(opp[current_level - 1].opp_id);
> #endif
>
Acked-by: Nishanth Menon <nm@ti.com>
>
> /* See if have a freq associated, if not, invalid opp */
>
next prev parent reply other threads:[~2009-12-19 12:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 23:05 [PATCH v2 0/4] OPP layer: hide OPP implementation details Kevin Hilman
2009-12-18 23:05 ` [PATCH v2 1/4] OMAP OPP: Add accessor function for getting OPP ID Kevin Hilman
2009-12-18 23:05 ` [PATCH v2 2/4] OMAP SRF: adjust OPP array access Kevin Hilman
2009-12-18 23:05 ` [PATCH v2 3/4] OMAP SR/SRF: use OPP API for OPP ID, remove direct access Kevin Hilman
2009-12-18 23:05 ` [PATCH v2 4/4] OMAP OPP: hide struct omap_opp internals in OPP layer implementation Kevin Hilman
2009-12-19 12:04 ` Menon, Nishanth
2009-12-19 12:03 ` [PATCH v2 3/4] OMAP SR/SRF: use OPP API for OPP ID, remove direct access Menon, Nishanth
2009-12-22 16:16 ` Kevin Hilman
2009-12-19 12:00 ` Menon, Nishanth [this message]
2009-12-19 11:56 ` [PATCH v2 1/4] OMAP OPP: Add accessor function for getting OPP ID Menon, Nishanth
2009-12-21 7:11 ` Romit Dasgupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2CC06A.3080503@ti.com \
--to=nm@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox